Больше деталей #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
Danila100
reviewed
Nov 30, 2024
js/main.js
Outdated
| @@ -0,0 +1,62 @@ | |||
| function takeARandomNumber(max, min = 0){ | |||
There was a problem hiding this comment.
Обычно когда функция что-то получает, ее начинают с глагола get. Это правило можно применять почти всегда)
js/main.js
Outdated
| } | ||
|
|
||
| function createArrayOfComments(){ | ||
| const comments = [ |
There was a problem hiding this comment.
Константы лучше вынести. Дальше будет задание на модули и их можно вообще в отдельный файл унести
There was a problem hiding this comment.
Сейчас вынес из функций, дальше распределю
js/main.js
Outdated
| const newComment = { | ||
| id: i + 1, | ||
| avatar: `img/avatar-${takeARandomNumber(6, 1)}.svg`, | ||
| message: takeARandomNumber(2,1) > 1 ? `${comments[takeARandomNumber(comments.length)]}/n${comments[takeARandomNumber(comments.length)]}` : comments[takeARandomNumber(comments.length)], |
There was a problem hiding this comment.
Если нужно будет 3 или больше комментов добавить, то что делать?)
There was a problem hiding this comment.
Сейчас написал код, в котором можно управлять границами
не сразу догадался)
Danila100
reviewed
Nov 30, 2024
js/main.js
Outdated
| for (let i = 0; i < 25; i++){ | ||
| const newPhoto = { | ||
| id : i + 1, | ||
| url: `photos/${i + 1}`, |
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
|
PR принят, все ок! 🙂 |
keksobot
merged commit a28cc1f
into
htmlacademy-univer-javascript-1:master
1 check passed
|
Можно делать деление на модули 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Больше деталей
💥 https://htmlacademy-univer-javascript-1.github.io/2579201-kekstagram-5/4/