Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*** COMPRESSION ERROR in simple. #8

Open
frkay opened this issue Jan 18, 2013 · 5 comments
Open

*** COMPRESSION ERROR in simple. #8

frkay opened this issue Jan 18, 2013 · 5 comments

Comments

@frkay
Copy link

frkay commented Jan 18, 2013

When compressing spiegel.de.har, other compressions work fine.

@grmocg
Copy link

grmocg commented Jan 18, 2013

yea, I'm sure there are some bugs in there. I"d ignore it for now unless it
is pervasive.
-=R

On Thu, Jan 17, 2013 at 5:16 PM, frkay [email protected] wrote:

When compressing spiegel.de.har, other compressions work fine.


Reply to this email directly or view it on GitHubhttps://github.com//issues/8.

@mnot
Copy link
Member

mnot commented Jan 18, 2013

This is caused by either:

  • dates not being reconstituted as the exact same string
  • the scheme not coming back (because it isn't preserved, much as in HTTP/1)

I'm going to adjust the comparison function to account for at least the date (as it'll be common in other compressors too, and we don't need that level of information to be preserved).

@mnot
Copy link
Member

mnot commented Jan 18, 2013

Oh, and you can find out why by passing a higher verbosity (e.g., -v 2, IIRC).

@grmocg
Copy link

grmocg commented Jan 18, 2013

yea, I'm sure there are some bugs in there. I"d ignore it for now unless it
is pervasive, my guess is that there are two exact copies of something in a
request or response.
-=R

On Thu, Jan 17, 2013 at 5:16 PM, frkay [email protected] wrote:

When compressing spiegel.de.har, other compressions work fine.


Reply to this email directly or view it on GitHubhttps://github.com//issues/8.

@mnot
Copy link
Member

mnot commented Jan 18, 2013

It's my simple compressor. E.g.,

- mismatch in simple: expires has mismatched values
  a -> Mon, 26 Jul 1997 05:00:00 GMT
  b -> Sat, 26 Jul 1997 05:00:00 GMT

I don't think any candidate compressor needs to preserve this much information :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants