Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdn/cache_history_tasks): refactor the cache_history_tasks data source code style #6152

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Jan 6, 2025

What this PR does / why we need it:

refactor the cache_history_tasks data source code style

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


refactor the `cache_history_tasks` data source code style

PR Checklist

  • Tests added/passed.
$ export HW_CDN_DOMAIN_URL=xxxxxxxxxx
$ make testacc TEST="./huaweicloud/services/acceptance/cdn" TESTARGS="-run TestAccDataSourCacheHistoryTasks_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cdn -v -run TestAccDataSourceCacheHistoryTasks_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCacheHistoryTasks_basic
=== PAUSE TestAccDataSourceCacheHistoryTasks_basic
=== CONT  TestAccDataSourceCacheHistoryTasks_basic
--- PASS: TestAccDataSourceCacheHistoryTasks_basic (14.28s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cdn       14.341s

Test case coverage

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@jinyangyang222 jinyangyang222 force-pushed the refactor-cdn/refactor-cache_history_tasks-codeStyle branch 2 times, most recently from f0b7ba7 to 00e8f1e Compare January 6, 2025 12:21
@jinyangyang222 jinyangyang222 force-pushed the refactor-cdn/refactor-cache_history_tasks-codeStyle branch from 00e8f1e to 77f3e72 Compare January 7, 2025 02:07
@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 7, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 4f84903 into huaweicloud:master Jan 7, 2025
23 checks passed
@jinyangyang222 jinyangyang222 deleted the refactor-cdn/refactor-cache_history_tasks-codeStyle branch January 15, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants