Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result property in eRoamingAcknowledgment mandatory or optional? #48

Open
ahzf opened this issue Dec 29, 2020 · 2 comments
Open

Result property in eRoamingAcknowledgment mandatory or optional? #48

ahzf opened this issue Dec 29, 2020 · 2 comments

Comments

@ahzf
Copy link

ahzf commented Dec 29, 2020

The result property in eRoamingAcknowledgment is mandatory here https://github.com/hubject/oicp/blob/master/OICP-2.3/OICP%202.3%20CPO/02_CPO_Services_and_Operations.asciidoc#eRoamingAcknowledgementmessage , but optional here https://github.com/hubject/oicp/blob/master/OICP-2.3/SWAGGER%20DOCUMENTATION/evse-api-docs-2.3.json

I think "mandatory" is correct.

@oicp-moderator
Copy link
Collaborator

Good morning ahzf,

Thank you for your comment. As it is mentioned in the documentation, the "Result" of the Acknowledgment, is mandatory. May I ask why do you think in the Swagger Documentation say it is Optional?

@ahzf
Copy link
Author

ahzf commented Mar 10, 2021

Then property "result" should be within the "required" array of swagger:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants