eRoamingAuthorizeStart Message Properties

[ahzf]

With the eRoamingAuthorizeStart message I found the following issues:

1. The given SessionID of the AuthorizeStart request is ignored on the portal. A SessionID is generated within the portal, but the SessionID within the response is empty (at least when there is not valid contract).
2. Why is there an EMPPartnerSessionID property within the request?
3. The PartnerProductID property within the request is not shown within the portal.

https://github.com/hubject/oicp/blob/master/OICP-2.3/OICP%202.3%20CPO/02_CPO_Services_and_Operations.asciidoc#eRoamingAuthorizeStartmessage

I managed to run a little test on QA. When I send as CPO:

{
  "OperatorID": "DE*XXX",
  "Identification": {
    "RFIDMifareFamilyIdentification": "11223344"
  },
  "EvseID": "DE*XXX*E*TEST*1",
  "PartnerProductID": "ATOMSTROM",
  "SessionID": "c60beed2-e2c5-46dd-b7de-d8183902c90e",
  "CPOPartnerSessionID": "81660034-a500-4988-a92a-3539d6758acd",
  "EMPPartnerSessionID": "75752da2-a79c-480b-ac73-c50f598eb885"
}

I will receive as EMP the following:

{
	"SessionID": "597cc8c8-d493-42b0-9680-28c6f0e270af",
	"CPOPartnerSessionID": "81660034-a500-4988-a92a-3539d6758acd",
	"EMPPartnerSessionID": "75752da2-a79c-480b-ac73-c50f598eb885",
	"OperatorID": "DE*XXX",
	"EvseID": "DE*XXX*E*TEST*1",
	"Identification": {
		"RFIDMifareFamilyIdentification": {
			"UID": "11223344"
		}
	},
	"PartnerProductID": "ATOMSTROM"
}

So you let the CPO set the EMPPartnerSessionID, which is a bit confusing, but you overwrite the normal SessionID.

As the SessionID and the EMPPartnerSessionID are "reserved property keys" within this process, I would suggest to return an error (Bad request) when those properties are sent by a CPO.