Cleanup _resize_with_antialiasing #10007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type hints, remove unused default args
sayakpaul
reviewed
Nov 25, 2024
| @@ -618,8 +618,7 @@ def __call__( | |||
|
|
|||
|
|
|||
| # resizing utils | |||
| # TODO: clean up later | |||
| def _resize_with_antialiasing(input, size, interpolation="bicubic", align_corners=True): | |||
There was a problem hiding this comment.
This utility is private so, probably okay to not touch it?
There was a problem hiding this comment.
Yes, I agree that it is okay to not touch it, but I also think that it is better to clean up even private utilities. Although it is written in TODO that it needs to be cleaned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hints, remove unused default args
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.