Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix grammar and phrasing issues (1, 2, 3) #62

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

CharlesCNorton
Copy link
Contributor

  1. Insert missing article "a":

    • Original: "This repo is work in progress..."
    • Revised: "This repo is a work in progress..." Rationale: The article "a" is needed before "work in progress" to make the sentence grammatically correct.
  2. Add "as well as" for parallelism:

    • Original: "...scripts to train and evaluate models as well generate synthetic data..."
    • Revised: "...scripts to train and evaluate models as well as generate synthetic data..." Rationale: "As well as" is the correct conjunction to link multiple verbs or verb phrases, improving clarity.
  3. Clarify GPU resource phrasing:

    • Original: "we used 2 nodes of 8xH100 each one..."
    • Revised: "we used 2 nodes, each with 8×H100 GPUs..." Rationale: This rewording removes redundant language ("each one") and more clearly states that each node has eight H100 GPUs.

1. Insert missing article "a":
   - Original: "This repo is work in progress..."
   - Revised:  "This repo is a work in progress..."
   Rationale:
     The article "a" is needed before "work in progress" to make the sentence grammatically correct.

2. Add "as well as" for parallelism:
   - Original: "...scripts to train and evaluate models as well generate synthetic data..."
   - Revised:  "...scripts to train and evaluate models as well as generate synthetic data..."
   Rationale:
     "As well as" is the correct conjunction to link multiple verbs or verb phrases, improving clarity.

3. Clarify GPU resource phrasing:
   - Original: "we used 2 nodes of 8xH100 each one..."
   - Revised:  "we used 2 nodes, each with 8×H100 GPUs..."
   Rationale:
     This rewording removes redundant language ("each one") and more clearly states that each node has eight H100 GPUs.
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@lewtun lewtun merged commit 8d37c5c into huggingface:main Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants