From f5d6b86dcedfdb163cba11f9bf365f611027ac4b Mon Sep 17 00:00:00 2001 From: CharlesCNorton <135471798+CharlesCNorton@users.noreply.github.com> Date: Sun, 26 Jan 2025 16:02:47 -0500 Subject: [PATCH] docs: fix grammar and phrasing issues (1, 2, 3) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. Insert missing article "a": - Original: "This repo is work in progress..." - Revised: "This repo is a work in progress..." Rationale: The article "a" is needed before "work in progress" to make the sentence grammatically correct. 2. Add "as well as" for parallelism: - Original: "...scripts to train and evaluate models as well generate synthetic data..." - Revised: "...scripts to train and evaluate models as well as generate synthetic data..." Rationale: "As well as" is the correct conjunction to link multiple verbs or verb phrases, improving clarity. 3. Clarify GPU resource phrasing: - Original: "we used 2 nodes of 8xH100 each one..." - Revised: "we used 2 nodes, each with 8×H100 GPUs..." Rationale: This rewording removes redundant language ("each one") and more clearly states that each node has eight H100 GPUs. --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 317dcc1d..860bf1c7 100644 --- a/README.md +++ b/README.md @@ -1,12 +1,12 @@ # Open R1 -*A fully open reproduction of DeepSeek-R1. This repo is work in progress, let's build it together!* +*A fully open reproduction of DeepSeek-R1. This repo is a work in progress, let's build it together!* ## Overview The goal of this repo is to build the missing pieces of the R1 pipeline such that everybody can reproduce and build on top of it. The project is simple by design and mostly consists of: -- `src/open_r1` contains the scripts to train and evaluate models as well generate synthetic data: +- `src/open_r1` contains the scripts to train and evaluate models as well as generate synthetic data: - `grpo.py`: trains a model with GRPO on a given dataset. - `sft.py`: simple SFT of a model on a dataset. - `evaluate.py`: evaluates a model on the R1 benchmarks. @@ -234,7 +234,7 @@ Take a look at the sample dataset at [HuggingFaceH4/numina-deepseek-r1-qwen-7b]( ### Generate data from DeepSeek-R1 -To run the bigger DeepSeek-R1, we used 2 nodes of 8xH100 each one, using the slurm file present in this repo at `slurm/generate.slurm`. First, install the dependencies: +To run the bigger DeepSeek-R1, we used 2 nodes, each with 8×H100 GPUs using the slurm file present in this repo at `slurm/generate.slurm`. First, install the dependencies: (for now we need to install the vllm dev wheel that [fixes the R1 cuda graph capture](https://github.com/vllm-project/vllm/commits/221d388cc5a836fa189305785ed7e887cea8b510/csrc/moe/moe_align_sum_kernels.cu)) ```shell