Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PREFIX_CACHING=0 does not disable prefix caching in v2.3.1 #2676

Open
2 of 4 tasks
sam-ulrich1 opened this issue Oct 21, 2024 · 2 comments
Open
2 of 4 tasks

PREFIX_CACHING=0 does not disable prefix caching in v2.3.1 #2676

sam-ulrich1 opened this issue Oct 21, 2024 · 2 comments

Comments

@sam-ulrich1
Copy link

System Info

Ubuntu 20.04 Host, Docker image v2.3.1

Information

  • Docker
  • The CLI directly

Tasks

  • An officially supported command
  • My own modifications

Reproduction

Launch docker image with PREFIX_CACHING=0 (or false) and prefix caching is still enabled

Expected behavior

Respect env var for prefix caching
@sam-ulrich1 sam-ulrich1 mentioned this issue Oct 21, 2024
Open
4 tasks
@sam-ulrich1
Copy link
Author

This also prevents you from using ATTENTION=paged since the prefix caching is always true which crashes the model shards on launch

@sam-ulrich1
Copy link
Author

To disable prefix caching you have to set both USE_PREFIX_CACHING=0 AND PREFIX_CACHING=0 in v2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sam-ulrich1