Add support for French dates #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve tweaked frwiki’s config tons of times to try to understand why the automatic detect of user talk page warning templates was not working properly. In fact it seems that the format of dates present in the signatures in French is different from English, since we put first the date and then the time while enwiki does the opposite, and frwiki specificity was not yet managed. This PR adds a bit of logic for French wikis, and adds a few bits of comments around the way. I think I managed the memory correctly but do not hesitate to check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve tweaked frwiki’s config tons of times to try to understand why the automatic detection of user talk page warning levels was not working properly.
In fact it seems that the format of dates present in the signatures in French is different from English, since we put first the date and then the time while enwiki does the opposite. French specificity was not managed at all yet.
This PR adds a bit of logic for French wikis, and adds a few comments around the way.
I think I managed the memory correctly but do not hesitate to check.
Bug: https://phabricator.wikimedia.org/T352815