Close the libusb handle if returning failure from open()

hughsie · Nov 20, 2023 · dcf596c · dcf596c
1 parent 860108f
commit dcf596c
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/gusb/gusb-device.c b/gusb/gusb-device.c
@@ -863,7 +863,15 @@ _g_usb_device_open_internal(GUsbDevice *self, GError **error)
 
 	/* open device */
 	rc = libusb_open(priv->device, &priv->handle);
-	return g_usb_device_libusb_error_to_gerror(self, rc, error);
+	if (!g_usb_device_libusb_error_to_gerror(self, rc, error)) {
+		if (priv->handle != NULL)
+			libusb_close(priv->handle);
+		priv->handle = NULL;
+		return FALSE;
+	}
+
+	/* success */
+	return TRUE;
 }
 
 /**