Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize "extended support" column and re-order date columns #191

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

elliotwutingfeng
Copy link
Contributor

The extendedSupport column is not colorized. This PR fixes it.

eol java

@hugovk hugovk added the changelog: Added For new features label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cab4e39) 98.98% compared to head (a6add52) 98.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   98.98%   98.99%   +0.01%     
==========================================
  Files           7        7              
  Lines         395      399       +4     
==========================================
+ Hits          391      395       +4     
  Misses          4        4              
Flag Coverage Δ
macos-latest 98.99% <100.00%> (+0.01%) ⬆️
ubuntu-latest 98.99% <100.00%> (+0.01%) ⬆️
windows-latest 98.99% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugovk
Copy link
Owner

hugovk commented Jan 24, 2024

Thank you!

Before

image

After

image

Let's keep the order the same, with extendedSupport after eol.

And let's rename extendedSupport to extended support, see lines 176-181.

@elliotwutingfeng
Copy link
Contributor Author

elliotwutingfeng commented Jan 24, 2024

Should discontinued be displayed before supported, like in https://endoflife.date/apple-watch and https://endoflife.date/intel-processors?

@hugovk
Copy link
Owner

hugovk commented Jan 24, 2024

Yes, we want the columns with earlier dates to come first.

@elliotwutingfeng elliotwutingfeng changed the title Colorize extendedSupport column Colorize extendedSupport column and re-order date columns Jan 24, 2024
@elliotwutingfeng elliotwutingfeng marked this pull request as draft January 24, 2024 17:14
@elliotwutingfeng elliotwutingfeng marked this pull request as ready for review January 24, 2024 17:31
@hugovk hugovk changed the title Colorize extendedSupport column and re-order date columns Colorize "extended support" column and re-order date columns Jan 24, 2024
@hugovk hugovk merged commit 56c7361 into hugovk:main Jan 24, 2024
31 checks passed
@hugovk
Copy link
Owner

hugovk commented Jan 24, 2024

Thanks again!

@elliotwutingfeng elliotwutingfeng deleted the extended branch January 24, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants