Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double encoding in registry creds #84

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

johanneswuerbach
Copy link
Contributor

There is currently when using a humanitec_registry resource with creds.

With a definition like:

resource "humanitec_registry" "my" {
  id        = "my"
  type      = "amazon_ecr"
  creds = {
    username = "aws"
    password = "key"
  }
}

The previous implementation would send a quoted string the API.

{ "creds": { "username": "\"aws\"", "password": "\"key\"" } }

Fix this to be properly encoded strings.

{ "creds": { "username": "aws", "password": "key" } }

Copy link
Contributor

@mateuszjenek mateuszjenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM!

@johanneswuerbach johanneswuerbach merged commit 0a6ea3e into main May 7, 2024
2 checks passed
@johanneswuerbach johanneswuerbach deleted the fix-creds branch May 7, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants