Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for .humctl file and deprecation notice for host attribute #85

Merged
merged 3 commits into from
May 8, 2024
Merged

Added support for .humctl file and deprecation notice for host attribute #85

merged 3 commits into from
May 8, 2024

Conversation

dharsanb
Copy link
Member

@dharsanb dharsanb commented May 8, 2024

@dharsanb dharsanb self-assigned this May 8, 2024
@dharsanb dharsanb force-pushed the humctl-file-support branch from cd14366 to 350f614 Compare May 8, 2024 04:04
johanneswuerbach
johanneswuerbach reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@johanneswuerbach johanneswuerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, some comments

internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
@dharsanb dharsanb marked this pull request as ready for review May 8, 2024 20:51
@dharsanb dharsanb requested a review from johanneswuerbach May 8, 2024 20:51
@dharsanb dharsanb force-pushed the humctl-file-support branch from e2107e4 to 9568fc8 Compare May 8, 2024 20:55
@dharsanb dharsanb requested review from a team, astromechza, delca85, docktorrr and mateuszjenek May 8, 2024 20:55
johanneswuerbach
johanneswuerbach approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@johanneswuerbach johanneswuerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dharsanb dharsanb merged commit 490929b into main May 8, 2024
2 checks passed
@dharsanb dharsanb deleted the humctl-file-support branch May 8, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneswuerbach johanneswuerbach johanneswuerbach approved these changes

@astromechza astromechza Awaiting requested review from astromechza astromechza was automatically assigned from humanitec/backend

@delca85 delca85 Awaiting requested review from delca85 delca85 was automatically assigned from humanitec/backend

@docktorrr docktorrr Awaiting requested review from docktorrr docktorrr was automatically assigned from humanitec/backend

@mateuszjenek mateuszjenek Awaiting requested review from mateuszjenek mateuszjenek was automatically assigned from humanitec/backend

Assignees

@dharsanb dharsanb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dharsanb @johanneswuerbach