Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to wp-cron.php should be disabled when Cavalcade is in use #104

Open
dd32 opened this issue Jul 20, 2020 · 2 comments
Open

Access to wp-cron.php should be disabled when Cavalcade is in use #104

dd32 opened this issue Jul 20, 2020 · 2 comments

Comments

@dd32
Copy link
Contributor

dd32 commented Jul 20, 2020

Although it shouldn't happen, and should potentially be blocked at the server level, when Cavalcade is in use requests to wp-cron.php will still process any cron tasks.

As seen in #103, this currently doesn't actually work as it triggers a fatal error, but that just clouds error logs.

Ideally, Cavalcade should probably block/terminate-early the HTTP request.

@roborourke
Copy link
Contributor

Hm, yeah you'd think setting DISABLE_WP_CRON to true would stop the file from working. Thanks for flagging this.

@peterwilsoncc
Copy link
Contributor

This part of Cavalcade is a storage engine, it’s compatible with wp-cli, wp-cron.php, and of course the Cavalcade runner.

If you must block wp-cron.php please only do it behind the constant and make it filterable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants