Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multibyte characters in args break when unserialising #85

Open
roborourke opened this issue Jun 10, 2019 · 4 comments
Open

Multibyte characters in args break when unserialising #85

roborourke opened this issue Jun 10, 2019 · 4 comments
Labels

Comments

@roborourke
Copy link
Contributor

Jobs containing args that contain multibyte unicode characters such as emoji can't be run as after they're serialised they do not unserialise correctly.

@roborourke roborourke added the Bug label Jun 10, 2019
@roborourke roborourke changed the title Multibyte characters break when unserialising Multibyte characters in args break when unserialising Jun 10, 2019
@rmccue
Copy link
Member

rmccue commented Jun 10, 2019

I believe this is an issue with the table and/or column encoding not supporting utf8mb4?

@roborourke
Copy link
Contributor Author

Yeah doesn't look like the db table creation scripts force utf8mb4.

@roborourke
Copy link
Contributor Author

Time for an upgrade_database_3() function I think.

@peterwilsoncc
Copy link
Contributor

I’ve started working on a third version of the DB scheme in #86 to account for the new preflight filters.

I might split it out the DB upgrade in to its own PR and incorporate this to avoid multiple upgrade steps.

WordPress core does some voodoo to support multibyte characters in older versions of MySQL.

I figure we can leave out the voodoo and limit the check to make sure the server supports multibyte characters. Without such support, Cavalcade doesn’t support the characters in arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants