Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images used from Global Media Library should not display in Local Media #167

Open
1 task
rmccue opened this issue Sep 15, 2021 · 3 comments
Open
1 task
Labels
bug Existing functionality isn't behaving as expected

Comments

@rmccue
Copy link
Member

rmccue commented Sep 15, 2021

Steps to reproduce:

  1. Upload an image to the Global Media Library
  2. On a site, insert the image from the Global Media Library into a piece of content
  3. View the media library for Local Media
  4. Observe the synched image now displays in Local Media

Images pulled across from the Global Media Library should not appear in the Local Media selection.

Acceptance criteria:

  • ...
@rmccue rmccue added the bug Existing functionality isn't behaving as expected label Sep 15, 2021
@roborourke
Copy link
Contributor

This is how AMF works / always has worked. The version in Local Media is the local reference to the external image. This is where you could make local edits to things like the caption etc.

As far as I'm aware it's the intended behaviour and not a bug.

@rmccue
Copy link
Member Author

rmccue commented Sep 15, 2021

OK, will change to an enhancement.

Also, I think we're the first people using the multiple provider support no? In a single provider world, AMF replaced the local library, so you couldn't see the duplicated images.

@roborourke
Copy link
Contributor

That is a good point, I'd forgotten about that. Certainly complicates things.

From a default WP behaviour perspective it's much much easier to show it in the local library as the modal filter would have to be switched to the appropriate provider programmatically depending on the currently selected image/media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Development

No branches or pull requests

2 participants