From 8a3a703b819a23c8cac41864da9550bd0a6ac6cb Mon Sep 17 00:00:00 2001
From: Joe Hoyle <joehoyle@gmail.com>
Date: Thu, 29 Feb 2024 11:14:42 +0200
Subject: [PATCH] PR feedback

---
 .github/workflows/test.yml   |  1 -
 tests/test-lambda.ts         |  4 ++--
 tests/test-private-upload.ts | 15 ++++++---------
 3 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 184c773..7debe4b 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -13,7 +13,6 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           node-version: 18.x
-      - run: env
       - run: npm install
       - run: npx jest
         env:
diff --git a/tests/test-lambda.ts b/tests/test-lambda.ts
index 7015c99..adaf7a3 100644
--- a/tests/test-lambda.ts
+++ b/tests/test-lambda.ts
@@ -60,8 +60,8 @@ global.awslambda = {
 	},
 	HttpResponseStream: {
 		/**
-		 * @param stream
-		 * @param metadata
+		 * @param stream The response stream.
+		 * @param metadata The metadata for the response.
 		 */
 		from( stream: ResponseStream, metadata ) : ResponseStream {
 			return stream;
diff --git a/tests/test-private-upload.ts b/tests/test-private-upload.ts
index cba832c..0bace85 100644
--- a/tests/test-private-upload.ts
+++ b/tests/test-private-upload.ts
@@ -1,4 +1,4 @@
-import { GetObjectCommand, S3Client, S3ClientConfig } from '@aws-sdk/client-s3';
+import { GetObjectCommand, S3Client } from '@aws-sdk/client-s3';
 import { getSignedUrl } from '@aws-sdk/s3-request-presigner';
 import { test, expect } from '@jest/globals';
 import { MiddlewareType } from '@smithy/types';
@@ -9,15 +9,12 @@ import { Args } from '../src/lib';
 /**
  * Presign a URL for a given key.
  * @param key
- * @returns {Promise<string>}
+ * @returns {Promise<Args>} The presigned params
  */
 async function getPresignedUrlParams( key: string ) : Promise<Args> {
-	const client = new S3Client(
-		{
-			region: process.env.S3_REGION,
-			bucket: process.env.S3_BUCKET,
-		} as S3ClientConfig
-	);
+	const client = new S3Client( {
+		region: process.env.S3_REGION,
+	} );
 	const command = new GetObjectCommand( {
 		Bucket: process.env.S3_BUCKET,
 		Key: key,
@@ -42,7 +39,7 @@ async function getPresignedUrlParams( key: string ) : Promise<Args> {
 	const presignedUrl = new URL( await getSignedUrl( client, command, {
 		expiresIn: 60,
 	} ) );
-	// console.log( presignedUrl );
+
 	let queryStringParameters: Args = {};
 	presignedUrl.searchParams.forEach( ( value, key ) => {
 		queryStringParameters[ key as keyof Args ] = value;