Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role mapping filter is always reset when using in network activated mode #95

Open
roborourke opened this issue Jan 15, 2025 · 0 comments · May be fixed by #96
Open

Role mapping filter is always reset when using in network activated mode #95

roborourke opened this issue Jan 15, 2025 · 0 comments · May be fixed by #96
Labels
bug

Comments

@roborourke
Copy link
Contributor

Because we don't return the roles early if not empty when filtered in get_user_roles_from_sso() they will always get clobbered by the if statement which sets a fresh empty array.

The function returns the $network_roles array if it is not null, but an empty array is not null.

https://github.com/humanmade/wp-simple-saml/blob/master/inc/namespace.php#L823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow get_user_role_from_sso to be filtered in multisite mode humanmade/wp-simple-saml
1 participant
@roborourke