Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: Stuck in Login Form #68

Open
felixhahnweilheim opened this issue Jan 24, 2025 · 5 comments
Open

App: Stuck in Login Form #68

felixhahnweilheim opened this issue Jan 24, 2025 · 5 comments

Comments

@felixhahnweilheim
Copy link

As the FCM module provides the "Switch Network" button I add this issue/feature request here.

When you add a new network in the app which has no guest access, you see the login page.
If you can't login (forgot password or so) you have no way to get out of this situation as the "Switch Network" button is not present, no back button, nothing.

Not sure about the best solution.
Maybe the button can just be added to the login page?

@marc-farre
Copy link
Contributor

That's a good point.

@luke- Should I add a button on the login form?

Image

@felixhahnweilheim
Copy link
Author

Actually I found other situations where you get stuck:

  • offline page
  • error message when the HumHub instance suddenly has a server error

In both cases the back button opens the dialog "Do you want to exit the app?"
If I press yes, the app closes. When I reopen it, I'm back in the same situation.

So it would also be a solution to replace the dialog with "Do you want to switch network?" or "Do you want to exit the network?" when the back button was pressed.

The good thing of a solution within the app is, it will work with every HumHub instance.

@luke-
Copy link
Contributor

luke- commented Jan 25, 2025

Hmm, wouldn't it be better if we could set the back button to jump back to the opener in these cases?

@marc-farre
Copy link
Contributor

The back button cannot solve this issue in all cases, because more and more Android devices are configured with the Gesture navigation mode (so no Back button), and iPhone nether had Back button.

But:

  • If the device is offline, there should be a link to refresh the page once it's online again
  • If the server is offline, of course, it's an issue, but should be really rare
  • If an error is displayed, the top menu "Sign in/up" button should be available

Alternatively, we could add the "Switch Network" button to the top menu, at the left of the "Sign in/up" button?
With Bootstrap 5, we could have an outlined button for it: https://getbootstrap.com/docs/5.3/components/buttons/#outline-buttons

Also, we could change the current behaviour of the app:
After the app is closed (what can be done on all devices), once opened again, the app Opener page is displayed, instead of the latest seen HH instance.

@luke- @felixhahnweilheim @PrimozRatej

@luke-
Copy link
Contributor

luke- commented Jan 25, 2025

The back button cannot solve this issue in all cases, because more and more Android devices are configured with the Gesture navigation mode (so no Back button), and iPhone nether had Back button.

Ok, thats right, if there is no "Back", then we need another solution.

But:

  • If the device is offline, there should be a link to refresh the page once it's online again
  • If the server is offline, of course, it's an issue, but should be really rare

👍 Yes, we should add a Retry button/option here. Do you want to create an issue/PR for this?

  • If an error is displayed, the top menu "Sign in/up" button should be available

Maybe just some Back or Home?

Alternatively, we could add the "Switch Network" button to the top menu, at the left of the "Sign in/up" button?

Does this also work for networks without open registration?

With Bootstrap 5, we could have an outlined button for it: https://getbootstrap.com/docs/5.3/components/buttons/#outline-buttons

We should start with a button concept before using some new button styles. We need to be consistent here. But I think that the “Secondary” button will be an outline button in the future...

Also, we could change the current behaviour of the app: After the app is closed (what can be done on all devices), once opened again, the app Opener page is displayed, instead of the latest seen HH instance.

Hmm, at least when multiple HumHubs configured, that could make sense.

@luke- @felixhahnweilheim @PrimozRatej

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants