Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processor: range queries - range check #22

Open
chrisreu opened this issue Jan 8, 2014 · 1 comment
Open

Processor: range queries - range check #22

chrisreu opened this issue Jan 8, 2014 · 1 comment
Labels
Milestone

Comments

@chrisreu
Copy link
Member

chrisreu commented Jan 8, 2014

Not correct now for all possible values. rangeValidator just checks for <=. I think this need to be performed in the normalized values, or at least be implemented for each CType seperatly. For now i disabled this for the position search.

Normalizer.hs

rangeValidator :: CType -> [Text] -> [Text] -> Bool
rangeValidator t from to = case t of
-- XXX TODO real range check for positions
CPosition -> True

Processor.hs

-- values form a valid range    
-- XXX fix range validation - normalized values should be compared
--    unless' (rangeValidator cType ls' hs')
--            400 $ "invalid range for context: " `T.append` rangeText
-- type determines the processing
@chrisreu chrisreu modified the milestones: 0.2, 0.3.0.0 Aug 10, 2014
@chrisreu chrisreu added the bug label Aug 11, 2014
@chrisreu
Copy link
Member Author

The issue still exists, but i think we can face it later.

@chrisreu chrisreu modified the milestones: 0.4.0.0, 0.3.0.0 Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant