Fix missing trim argument

Required in case of root outputs so that the route key is relative
hydephp · Dec 18, 2023 · 0f8fe02 · 0f8fe02
1 parent 89c6352
commit 0f8fe02
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/framework/src/Framework/Features/Documentation/DocumentationSearchPage.php b/packages/framework/src/Framework/Features/Documentation/DocumentationSearchPage.php
@@ -51,7 +51,7 @@ public static function enabled(): bool
 
     public static function routeKey(): string
     {
-        return ltrim(DocumentationPage::outputDirectory().'/search');
+        return ltrim(DocumentationPage::outputDirectory().'/search', '/');
     }
 
     protected static function anotherSearchPageExists(): bool

diff --git a/packages/framework/tests/Feature/DocumentationSearchPageTest.php b/packages/framework/tests/Feature/DocumentationSearchPageTest.php
@@ -70,4 +70,10 @@ public function testStaticRouteKeyHelperWithCustomOutputDirectory()
         DocumentationPage::setOutputDirectory('foo');
         $this->assertSame('foo/search', DocumentationSearchPage::routeKey());
     }
+
+    public function testStaticRouteKeyHelperWithRootOutputDirectory()
+    {
+        DocumentationPage::setOutputDirectory('');
+        $this->assertSame('search', DocumentationSearchPage::routeKey());
+    }
 }