Refactor to move Blade mocks into closure

hydephp · Jun 26, 2024 · 4868497 · 4868497
1 parent 5e7869f
commit 4868497
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/packages/framework/tests/Unit/IncludesFacadeUnitTest.php b/packages/framework/tests/Unit/IncludesFacadeUnitTest.php
@@ -157,31 +157,31 @@ public function testMarkdownWithAndWithoutExtension()
     public function testBladeReturnsRenderedPartial()
     {
         $filename = 'foo.blade.php';
-        $content = '{{ "foo bar" }}';
         $expected = 'foo bar';
 
-        $this->mockFilesystem(function ($filesystem) use ($content, $filename) {
+        $this->mockFilesystem(function ($filesystem) use ($expected, $filename) {
+            $content = '{{ "foo bar" }}';
             $filesystem->shouldReceive('exists')->with(Hyde::path('resources/includes/'.$filename))->andReturn(true);
             $filesystem->shouldReceive('get')->with(Hyde::path('resources/includes/'.$filename))->andReturn($content);
-        });
 
-        Blade::shouldReceive('render')->with($content)->andReturn($expected);
+            Blade::shouldReceive('render')->with($content)->andReturn($expected);
+        });
 
         $this->assertSame($expected, Includes::blade($filename));
     }
 
     public function testBladeWithAndWithoutExtension()
     {
-        $content = '{{ "foo bar" }}';
-        $expected = 'foo bar';
 
-        $this->mockFilesystem(function ($filesystem) use ($content) {
+        $this->mockFilesystem(function ($filesystem) {
+            $expected = 'foo bar';
+            $content = '{{ "foo bar" }}';
             $filename = 'foo.blade.php';
             $filesystem->shouldReceive('exists')->with(Hyde::path('resources/includes/'.$filename))->andReturn(true);
             $filesystem->shouldReceive('get')->with(Hyde::path('resources/includes/'.$filename))->andReturn($content);
-        });
 
-        Blade::shouldReceive('render')->with($content)->andReturn($expected);
+            Blade::shouldReceive('render')->with($content)->andReturn($expected);
+        });
 
         $this->assertSame(Includes::blade('foo.blade.php'), Includes::blade('foo'));
     }
@@ -192,12 +192,11 @@ public function testBladeReturnsDefaultValueWhenNotFound()
         $default = '{{ "default" }}';
         $expected = 'default';
 
-        $this->mockFilesystem(function ($filesystem) use ($filename) {
+        $this->mockFilesystem(function ($filesystem) use ($default, $expected, $filename) {
             $filesystem->shouldReceive('exists')->with(Hyde::path('resources/includes/'.$filename))->andReturn(false);
+            Blade::shouldReceive('render')->with($default)->andReturn($expected);
         });
 
-        Blade::shouldReceive('render')->with($default)->andReturn($expected);
-
         $this->assertNull(Includes::blade($filename));
         $this->assertSame($expected, Includes::blade($filename, $default));
     }