Add break to prevent endless recursion loop

hydephp · Oct 28, 2023 · 630fa09 · 630fa09
1 parent 878d359
commit 630fa09
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/packages/framework/src/Console/Concerns/BetterChoiceHelper.php b/packages/framework/src/Console/Concerns/BetterChoiceHelper.php
@@ -5,6 +5,7 @@
 namespace Hyde\Console\Concerns;
 
 use Closure;
+use RuntimeException;
 use Symfony\Component\Console\Helper\Helper;
 use Symfony\Component\Console\Question\Question;
 use Symfony\Component\Console\Output\NullOutput;
@@ -53,6 +54,11 @@ protected function betterChoice(string $question, array $choices, int|string $de
         $selection = $choices[$answer] ?? null;
 
         if ($selection === null) {
+            // High enough to not impact normal usage, but low enough to break loops
+            if ($this->retryCount > 30) {
+                throw new RuntimeException('Maximum retries exceeded');
+            }
+
             $this->retryCount++;
             $this->output->error(sprintf('Invalid option "%s"', $answer));
             $this->betterChoice(...func_get_args());