From 83cfa5abb76e0bae24bda7e977855d1e0202b4fe Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Mon, 18 Dec 2023 15:52:35 +0100
Subject: [PATCH] Inline simplified helper

---
 .../views/components/docs/search-scripts.blade.php   |  2 +-
 .../Actions/GeneratesDocumentationSearchIndex.php    |  2 +-
 .../Documentation/DocumentationSearchIndex.php       |  7 +------
 .../tests/Feature/DocumentationSearchIndexTest.php   | 12 ++++++------
 4 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/packages/framework/resources/views/components/docs/search-scripts.blade.php b/packages/framework/resources/views/components/docs/search-scripts.blade.php
index f2561c84b61..6da5968e532 100644
--- a/packages/framework/resources/views/components/docs/search-scripts.blade.php
+++ b/packages/framework/resources/views/components/docs/search-scripts.blade.php
@@ -1,7 +1,7 @@
 <script src="https://cdn.jsdelivr.net/npm/hydesearch@0.2.1/dist/HydeSearch.min.js" defer></script>
 <script>
     window.addEventListener('load', function () {
-        const searchIndexLocation = '{{ Hyde::relativeLink(\Hyde\Framework\Features\Documentation\DocumentationSearchIndex::routeKey()) }}';
+        const searchIndexLocation = '{{ Hyde::relativeLink(\Hyde\Framework\Features\Documentation\DocumentationSearchIndex::outputPath()) }}';
         const Search = new HydeSearch(searchIndexLocation);
 
         Search.init();
diff --git a/packages/framework/src/Framework/Actions/GeneratesDocumentationSearchIndex.php b/packages/framework/src/Framework/Actions/GeneratesDocumentationSearchIndex.php
index cf55338757c..45f7a24c5e9 100644
--- a/packages/framework/src/Framework/Actions/GeneratesDocumentationSearchIndex.php
+++ b/packages/framework/src/Framework/Actions/GeneratesDocumentationSearchIndex.php
@@ -102,7 +102,7 @@ protected function formatDestination(string $slug): string
 
     protected function getPath(): string
     {
-        return Hyde::sitePath(DocumentationSearchIndex::routeKey());
+        return Hyde::sitePath(DocumentationSearchIndex::outputPath());
     }
 
     protected function getPagesToExcludeFromSearch(): array
diff --git a/packages/framework/src/Framework/Features/Documentation/DocumentationSearchIndex.php b/packages/framework/src/Framework/Features/Documentation/DocumentationSearchIndex.php
index 68b927b45d7..5ec5b32db00 100644
--- a/packages/framework/src/Framework/Features/Documentation/DocumentationSearchIndex.php
+++ b/packages/framework/src/Framework/Features/Documentation/DocumentationSearchIndex.php
@@ -19,7 +19,7 @@ class DocumentationSearchIndex extends InMemoryPage
      */
     public function __construct()
     {
-        parent::__construct(static::routeKey(), [
+        parent::__construct(DocumentationSearchIndex::outputPath(), [
             'navigation' => ['hidden' => true],
         ]);
     }
@@ -33,9 +33,4 @@ public static function outputPath(string $identifier = ''): string
     {
         return RouteKey::fromPage(DocumentationPage::class, 'search').'.json';
     }
-
-    public static function routeKey(): string
-    {
-        return static::outputPath();
-    }
 }
diff --git a/packages/framework/tests/Feature/DocumentationSearchIndexTest.php b/packages/framework/tests/Feature/DocumentationSearchIndexTest.php
index 77c51e57052..7cc9b8939d7 100644
--- a/packages/framework/tests/Feature/DocumentationSearchIndexTest.php
+++ b/packages/framework/tests/Feature/DocumentationSearchIndexTest.php
@@ -34,20 +34,20 @@ public function testRouteKeyIsSetToConfiguredDocumentationOutputDirectory()
         $this->assertSame('foo/search.json', $page->routeKey);
     }
 
-    public function testStaticRouteKeyHelper()
+    public function testStaticOutputPathHelper()
     {
-        $this->assertSame('docs/search.json', DocumentationSearchIndex::routeKey());
+        $this->assertSame('docs/search.json', DocumentationSearchIndex::outputPath());
     }
 
-    public function testStaticRouteKeyHelperWithCustomOutputDirectory()
+    public function testStaticOutputPathHelperWithCustomOutputDirectory()
     {
         DocumentationPage::setOutputDirectory('foo');
-        $this->assertSame('foo/search.json', DocumentationSearchIndex::routeKey());
+        $this->assertSame('foo/search.json', DocumentationSearchIndex::outputPath());
     }
 
-    public function testStaticRouteKeyHelperWithRootOutputDirectory()
+    public function testStaticOutputPathHelperWithRootOutputDirectory()
     {
         DocumentationPage::setOutputDirectory('');
-        $this->assertSame('search.json', DocumentationSearchIndex::routeKey());
+        $this->assertSame('search.json', DocumentationSearchIndex::outputPath());
     }
 }