From b7a253777b8c0caca3d697f679fba3bb30450810 Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Mon, 18 Dec 2023 11:43:30 +0100
Subject: [PATCH] Extract internal route key helper

Reduces the amount of times and places we call the exact same logic
---
 .../components/docs/search-scripts.blade.php    |  2 +-
 .../GeneratesDocumentationSearchIndex.php       |  3 ++-
 .../Documentation/DocumentationSearchIndex.php  |  9 ++++++++-
 .../Feature/DocumentationSearchIndexTest.php    | 17 +++++++++++++++++
 4 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/packages/framework/resources/views/components/docs/search-scripts.blade.php b/packages/framework/resources/views/components/docs/search-scripts.blade.php
index 0d381221c29..f2561c84b61 100644
--- a/packages/framework/resources/views/components/docs/search-scripts.blade.php
+++ b/packages/framework/resources/views/components/docs/search-scripts.blade.php
@@ -1,7 +1,7 @@
 <script src="https://cdn.jsdelivr.net/npm/hydesearch@0.2.1/dist/HydeSearch.min.js" defer></script>
 <script>
     window.addEventListener('load', function () {
-        const searchIndexLocation = '{{ Hyde::relativeLink(ltrim(DocumentationPage::outputDirectory().'/search.json', '/')) }}';
+        const searchIndexLocation = '{{ Hyde::relativeLink(\Hyde\Framework\Features\Documentation\DocumentationSearchIndex::routeKey()) }}';
         const Search = new HydeSearch(searchIndexLocation);
 
         Search.init();
diff --git a/packages/framework/src/Framework/Actions/GeneratesDocumentationSearchIndex.php b/packages/framework/src/Framework/Actions/GeneratesDocumentationSearchIndex.php
index 64bbb7d8e67..cf55338757c 100644
--- a/packages/framework/src/Framework/Actions/GeneratesDocumentationSearchIndex.php
+++ b/packages/framework/src/Framework/Actions/GeneratesDocumentationSearchIndex.php
@@ -10,6 +10,7 @@
 use Hyde\Framework\Concerns\InteractsWithDirectories;
 use Hyde\Pages\DocumentationPage;
 use Illuminate\Support\Collection;
+use Hyde\Framework\Features\Documentation\DocumentationSearchIndex;
 
 use function basename;
 use function in_array;
@@ -101,7 +102,7 @@ protected function formatDestination(string $slug): string
 
     protected function getPath(): string
     {
-        return Hyde::sitePath(DocumentationPage::outputDirectory().'/search.json');
+        return Hyde::sitePath(DocumentationSearchIndex::routeKey());
     }
 
     protected function getPagesToExcludeFromSearch(): array
diff --git a/packages/framework/src/Framework/Features/Documentation/DocumentationSearchIndex.php b/packages/framework/src/Framework/Features/Documentation/DocumentationSearchIndex.php
index 2cb5aab6298..5d88dbc7a41 100644
--- a/packages/framework/src/Framework/Features/Documentation/DocumentationSearchIndex.php
+++ b/packages/framework/src/Framework/Features/Documentation/DocumentationSearchIndex.php
@@ -8,6 +8,8 @@
 use Hyde\Pages\DocumentationPage;
 use Hyde\Framework\Actions\GeneratesDocumentationSearchIndex;
 
+use function ltrim;
+
 /**
  * @internal This page is used to render the search index for the documentation.
  */
@@ -18,7 +20,7 @@ class DocumentationSearchIndex extends InMemoryPage
      */
     public function __construct()
     {
-        parent::__construct(ltrim(DocumentationPage::outputDirectory().'/search.json', '/'), [
+        parent::__construct(static::routeKey(), [
             'navigation' => ['hidden' => true],
         ]);
     }
@@ -29,6 +31,11 @@ public function compile(): string
     }
 
     public function getOutputPath(): string
+    {
+        return static::routeKey();
+    }
+
+    public static function routeKey(): string
     {
         return ltrim(DocumentationPage::outputDirectory().'/search.json', '/');
     }
diff --git a/packages/framework/tests/Feature/DocumentationSearchIndexTest.php b/packages/framework/tests/Feature/DocumentationSearchIndexTest.php
index 58de0d066dd..77c51e57052 100644
--- a/packages/framework/tests/Feature/DocumentationSearchIndexTest.php
+++ b/packages/framework/tests/Feature/DocumentationSearchIndexTest.php
@@ -33,4 +33,21 @@ public function testRouteKeyIsSetToConfiguredDocumentationOutputDirectory()
         $page = new DocumentationSearchIndex();
         $this->assertSame('foo/search.json', $page->routeKey);
     }
+
+    public function testStaticRouteKeyHelper()
+    {
+        $this->assertSame('docs/search.json', DocumentationSearchIndex::routeKey());
+    }
+
+    public function testStaticRouteKeyHelperWithCustomOutputDirectory()
+    {
+        DocumentationPage::setOutputDirectory('foo');
+        $this->assertSame('foo/search.json', DocumentationSearchIndex::routeKey());
+    }
+
+    public function testStaticRouteKeyHelperWithRootOutputDirectory()
+    {
+        DocumentationPage::setOutputDirectory('');
+        $this->assertSame('search.json', DocumentationSearchIndex::routeKey());
+    }
 }