From 3eede9ebf78886e5803fb26f03e41a9c9c1551cd Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Fri, 28 Jun 2024 21:44:54 +0200 Subject: [PATCH 1/3] Remove Git version from debug screen --- packages/framework/src/Console/Commands/DebugCommand.php | 1 - .../framework/tests/Feature/Commands/DebugCommandTest.php | 8 -------- 2 files changed, 9 deletions(-) diff --git a/packages/framework/src/Console/Commands/DebugCommand.php b/packages/framework/src/Console/Commands/DebugCommand.php index cd87f65c5d4..ce995e395ed 100644 --- a/packages/framework/src/Console/Commands/DebugCommand.php +++ b/packages/framework/src/Console/Commands/DebugCommand.php @@ -40,7 +40,6 @@ public function handle(): int $this->info('HydePHP Debug Screen'); $this->newLine(); - $this->comment('Git Version: '.(string) app('git.version')); $this->comment('Hyde Version: '.((InstalledVersions::isInstalled('hyde/hyde') ? InstalledVersions::getPrettyVersion('hyde/hyde') : null) ?: 'unreleased')); $this->comment('Framework Version: '.(InstalledVersions::getPrettyVersion('hyde/framework') ?: 'unreleased')); $this->newLine(); diff --git a/packages/framework/tests/Feature/Commands/DebugCommandTest.php b/packages/framework/tests/Feature/Commands/DebugCommandTest.php index 9d0c72dce8d..2023de844c4 100644 --- a/packages/framework/tests/Feature/Commands/DebugCommandTest.php +++ b/packages/framework/tests/Feature/Commands/DebugCommandTest.php @@ -15,13 +15,6 @@ */ class DebugCommandTest extends TestCase { - protected function setUp(): void - { - parent::setUp(); - - $this->app->bind('git.version', fn () => 'foo'); - } - public function testDebugCommandCanRun() { $this->artisan('debug')->assertExitCode(0); @@ -31,7 +24,6 @@ public function testItPrintsDebugInformation() { $this->artisan('debug') ->expectsOutput('HydePHP Debug Screen') - ->expectsOutputToContain('Git Version:') ->expectsOutputToContain('Hyde Version:') ->expectsOutputToContain('Framework Version:') ->expectsOutputToContain('App Env:') From e4959f166d9d1d585f89c2a2a71f3e1a88daf7a8 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Fri, 28 Jun 2024 21:42:52 +0200 Subject: [PATCH 2/3] Remove Git version from dashboard table --- packages/realtime-compiler/src/Http/DashboardController.php | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/realtime-compiler/src/Http/DashboardController.php b/packages/realtime-compiler/src/Http/DashboardController.php index 5b1a27ec5a9..ad20b359991 100644 --- a/packages/realtime-compiler/src/Http/DashboardController.php +++ b/packages/realtime-compiler/src/Http/DashboardController.php @@ -122,7 +122,6 @@ public function getVersion(): string public function getProjectInformation(): array { return [ - 'Git Version' => app('git.version'), 'Hyde Version' => self::getPackageVersion('hyde/hyde'), 'Framework Version' => self::getPackageVersion('hyde/framework'), 'Project Path' => Hyde::path(), From a2dfeb8ba6cf663e19fd67e5c8281fe64fcb6887 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Fri, 28 Jun 2024 21:52:09 +0200 Subject: [PATCH 3/3] Update RELEASE_NOTES.md --- RELEASE_NOTES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 3c7bf8b6ae5..3f11e9a0b9c 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -26,7 +26,7 @@ This serves two purposes: - Deprecated the global `unslash()` function, replaced with the existing namespaced `\Hyde\unslash()` function in https://github.com/hydephp/develop/pull/1753 ### Removed -- for now removed features. +- The Git version is no longer displayed in the debug screen and dashboard in https://github.com/hydephp/develop/pull/1756 ### Fixed - Fixed explicitly set front matter navigation group behavior being dependent on subdirectory configuration, fixing https://github.com/hydephp/develop/issues/1515 in https://github.com/hydephp/develop/pull/1703