We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need to handle cases where a site URL is not set better. For example, deploying using the Action and a hyde.yml file, the following gets added:
<link rel="canonical" href="http://localhost"> <link rel="sitemap" href="http://localhost/sitemap.xml" type="application/xml" title="Sitemap">
I don't think this is ever desirable, as localhost URLs will never be valid in production, and locally aa relative URL will still be resolved.
So, I think we need to add broad level tests to ensure no localhosts get added to builds.
Additionally, we need relative links to sitemaps, and we should only add canonical tags when they are valid - and localhost are not.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
We need to handle cases where a site URL is not set better. For example, deploying using the Action and a hyde.yml file, the following gets added:
I don't think this is ever desirable, as localhost URLs will never be valid in production, and locally aa relative URL will still be resolved.
So, I think we need to add broad level tests to ensure no localhosts get added to builds.
Additionally, we need relative links to sitemaps, and we should only add canonical tags when they are valid - and localhost are not.
The text was updated successfully, but these errors were encountered: