Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update realtime compiler dashboard to block unsafe requests #1434

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update realtime compiler dashboard to block unsafe requests #1434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/realtime-compiler/src/Http/DashboardController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ public function __construct()
}

try {
$this->blockUnsafeRequests();
$this->handlePostRequest();
} catch (HttpException $exception) {
if (! $this->isAsync) {
Expand Down Expand Up @@ -472,6 +473,21 @@ protected static function getPackageVersion(string $packageName): string
return $prettyVersion ?? 'unreleased';
}

protected function blockUnsafeRequests(): void
{
// As the dashboard is not password-protected, and it can make changes to the file system,
// we block any requests that are not coming from the host machine. While we are clear
// in the documentation that the realtime compiler should only be used for local
// development, we still want to be extra careful in case someone forgets.

$requestIp = $_SERVER['REMOTE_ADDR'];
$allowedIps = ['::1', '127.0.0.1', 'localhost'];

if (! in_array($requestIp, $allowedIps, true)) {
$this->abort(403, "Refusing to serve request from address '$requestIp' (must be on localhost)");
}
}

protected function sendJsonResponse(int $statusCode, string $body): never
{
$statusMessage = match ($statusCode) {
Expand Down
Loading