From d5bea3126c12e283902f028844aef34f92cfeeb6 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:20:23 +0100 Subject: [PATCH 01/16] Copy over all test files for testing workflow --- .github/workflows/run-tests.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 76b1488c..5c881682 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -33,19 +33,23 @@ jobs: git clone -b develop https://github.com/hydephp/hyde.git fi - - name: Copy over framework source code + - name: Copy over framework code shell: bash run: | mkdir -p ./hyde/packages/hyde/framework/src + mkdir -p ./hyde/packages/hyde/framework/tests - # Since we can't use rsync on Windows, we need to copy the files to a temporary directory and then copy them back if [ "${{ matrix.os }}" == "windows-latest" ]; then + # For Windows, copy to temp then back to preserve structure mkdir ../temp cp -r ./ ../temp rm -rf ../temp/hyde - cp -r ../temp/. ./hyde/packages/hyde/framework/src + cp -r ../temp/src/. ./hyde/packages/hyde/framework/src + cp -r ../temp/tests/. ./hyde/packages/hyde/framework/tests else - rsync -a --exclude=hyde ./. ./hyde/packages/hyde/framework/src + # For Unix systems, use rsync + rsync -a --exclude=hyde ./src/. ./hyde/packages/hyde/framework/src + rsync -a --exclude=hyde ./tests/. ./hyde/packages/hyde/framework/tests fi - name: Update composer.json to load framework from local source From db858fdc3c115c23e63c5b1eb2517af5f318a119 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:23:05 +0100 Subject: [PATCH 02/16] Use main PHPUnit configuration --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 5c881682..65a39725 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -59,7 +59,7 @@ jobs: composer require hyde/testing:dev-master hyde/framework:dev-develop - name: Download test runner configuration - run: cd hyde && curl https://raw.githubusercontent.com/hydephp/develop/master/packages/hyde/phpunit.xml.dist -o phpunit.xml.dist + run: cd hyde && curl https://raw.githubusercontent.com/hydephp/develop/master/phpunit.xml.dist -o phpunit.xml.dist - name: Set environment to testing run: cd hyde && echo "ENV=testing" > .env From 0c9208d7ff4ccaebc6d2d7d8af7eefb5199ebaf5 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:30:18 +0100 Subject: [PATCH 03/16] Revert "Use main PHPUnit configuration" This reverts commit db858fdc3c115c23e63c5b1eb2517af5f318a119. --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 65a39725..5c881682 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -59,7 +59,7 @@ jobs: composer require hyde/testing:dev-master hyde/framework:dev-develop - name: Download test runner configuration - run: cd hyde && curl https://raw.githubusercontent.com/hydephp/develop/master/phpunit.xml.dist -o phpunit.xml.dist + run: cd hyde && curl https://raw.githubusercontent.com/hydephp/develop/master/packages/hyde/phpunit.xml.dist -o phpunit.xml.dist - name: Set environment to testing run: cd hyde && echo "ENV=testing" > .env From 0f09e0f3c0551915f0ac8eae50596a0082131e2b Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:31:34 +0100 Subject: [PATCH 04/16] Add the framework tests directory to the test suite --- .github/workflows/run-tests.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 5c881682..15c3817f 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -58,8 +58,12 @@ jobs: composer config repositories.framework path ./packages/hyde/framework composer require hyde/testing:dev-master hyde/framework:dev-develop - - name: Download test runner configuration - run: cd hyde && curl https://raw.githubusercontent.com/hydephp/develop/master/packages/hyde/phpunit.xml.dist -o phpunit.xml.dist + - name: Download and update test runner configuration + shell: bash + run: | + cd hyde + curl https://raw.githubusercontent.com/hydephp/develop/master/packages/hyde/phpunit.xml.dist -o phpunit.xml.dist + sed -i.bak '/.\\/tests<\\/directory>/a\\ .\/packages\/hyde\/framework\/tests<\/directory>' phpunit.xml.dist - name: Set environment to testing run: cd hyde && echo "ENV=testing" > .env From 6fcd37ec49fe549c57c876b5ab381cb387b0830b Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:34:01 +0100 Subject: [PATCH 05/16] Create phpunit.xml.dist --- tests/phpunit.xml.dist | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 tests/phpunit.xml.dist diff --git a/tests/phpunit.xml.dist b/tests/phpunit.xml.dist new file mode 100644 index 00000000..02ea5e48 --- /dev/null +++ b/tests/phpunit.xml.dist @@ -0,0 +1,18 @@ + + + + + ./tests + + + + + ./app + ./src + + + From 1ebaf92bafafee6d6d65c73d86dacdac87713b28 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:34:12 +0100 Subject: [PATCH 06/16] Update phpunit.xml.dist --- tests/phpunit.xml.dist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/phpunit.xml.dist b/tests/phpunit.xml.dist index 02ea5e48..487a26f3 100644 --- a/tests/phpunit.xml.dist +++ b/tests/phpunit.xml.dist @@ -7,12 +7,14 @@ ./tests + ./packages/hyde/framework/tests ./app ./src + ./packages/hyde/framework/src From 1dae84ed08d49e7b4671bc4d893fcbfa056cb66a Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:35:17 +0100 Subject: [PATCH 07/16] Move test runner configuration --- .github/workflows/run-tests.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 15c3817f..b7a41f95 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -58,12 +58,9 @@ jobs: composer config repositories.framework path ./packages/hyde/framework composer require hyde/testing:dev-master hyde/framework:dev-develop - - name: Download and update test runner configuration + - name: Move test runner configuration shell: bash - run: | - cd hyde - curl https://raw.githubusercontent.com/hydephp/develop/master/packages/hyde/phpunit.xml.dist -o phpunit.xml.dist - sed -i.bak '/.\\/tests<\\/directory>/a\\ .\/packages\/hyde\/framework\/tests<\/directory>' phpunit.xml.dist + run: cp tests/phpunit.xml.dist hyde/phpunit.xml.dist - name: Set environment to testing run: cd hyde && echo "ENV=testing" > .env From 62b18256cd769b6cde434ab87e5aa2549032d734 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:41:10 +0100 Subject: [PATCH 08/16] Stub abstracted tests for future update --- tests/Unit/Pages/BladePageUnitTest.php | 5 +++++ tests/Unit/Pages/DocumentationPageUnitTest.php | 5 +++++ tests/Unit/Pages/HtmlPageUnitTest.php | 5 +++++ tests/Unit/Pages/InMemoryPageUnitTest.php | 5 +++++ tests/Unit/Pages/MarkdownPageUnitTest.php | 5 +++++ tests/Unit/Pages/MarkdownPostUnitTest.php | 5 +++++ 6 files changed, 30 insertions(+) diff --git a/tests/Unit/Pages/BladePageUnitTest.php b/tests/Unit/Pages/BladePageUnitTest.php index fe1834b0..f15f4292 100644 --- a/tests/Unit/Pages/BladePageUnitTest.php +++ b/tests/Unit/Pages/BladePageUnitTest.php @@ -179,4 +179,9 @@ public function testMatter() { $this->assertInstanceOf(FrontMatter::class, (new BladePage('foo'))->matter()); } + + public function testGetCanonicalUrl() + { + $this->markTestSkipped('Not yet implemented'); + } } diff --git a/tests/Unit/Pages/DocumentationPageUnitTest.php b/tests/Unit/Pages/DocumentationPageUnitTest.php index 4017fcf6..b1ea51dd 100644 --- a/tests/Unit/Pages/DocumentationPageUnitTest.php +++ b/tests/Unit/Pages/DocumentationPageUnitTest.php @@ -202,4 +202,9 @@ public function testSave() $this->assertFileExists('_docs/foo.md'); Filesystem::unlink('_docs/foo.md'); } + + public function testGetCanonicalUrl() + { + $this->markTestSkipped('Not yet implemented'); + } } diff --git a/tests/Unit/Pages/HtmlPageUnitTest.php b/tests/Unit/Pages/HtmlPageUnitTest.php index f5f299fd..ac9f12cd 100644 --- a/tests/Unit/Pages/HtmlPageUnitTest.php +++ b/tests/Unit/Pages/HtmlPageUnitTest.php @@ -217,4 +217,9 @@ public function testMatter() { $this->assertInstanceOf(FrontMatter::class, (new HtmlPage('404'))->matter()); } + + public function testGetCanonicalUrl() + { + $this->markTestSkipped('Not yet implemented'); + } } diff --git a/tests/Unit/Pages/InMemoryPageUnitTest.php b/tests/Unit/Pages/InMemoryPageUnitTest.php index b2a9c2e6..6c913084 100644 --- a/tests/Unit/Pages/InMemoryPageUnitTest.php +++ b/tests/Unit/Pages/InMemoryPageUnitTest.php @@ -221,4 +221,9 @@ public function testMatter() { $this->assertInstanceOf(FrontMatter::class, (new InMemoryPage('404'))->matter()); } + + public function testGetCanonicalUrl() + { + $this->markTestSkipped('Not yet implemented'); + } } diff --git a/tests/Unit/Pages/MarkdownPageUnitTest.php b/tests/Unit/Pages/MarkdownPageUnitTest.php index 42a51565..1c04e970 100644 --- a/tests/Unit/Pages/MarkdownPageUnitTest.php +++ b/tests/Unit/Pages/MarkdownPageUnitTest.php @@ -230,4 +230,9 @@ public function testSave() $this->assertFileExists('_pages/foo.md'); Filesystem::unlink('_pages/foo.md'); } + + public function testGetCanonicalUrl() + { + $this->markTestSkipped('Not yet implemented'); + } } diff --git a/tests/Unit/Pages/MarkdownPostUnitTest.php b/tests/Unit/Pages/MarkdownPostUnitTest.php index 4ed8dfbe..ade5e74b 100644 --- a/tests/Unit/Pages/MarkdownPostUnitTest.php +++ b/tests/Unit/Pages/MarkdownPostUnitTest.php @@ -230,4 +230,9 @@ public function testSave() $this->assertFileExists('_posts/foo.md'); Filesystem::unlink('_posts/foo.md'); } + + public function testGetCanonicalUrl() + { + $this->markTestSkipped('Not yet implemented'); + } } From 6355a24e9d5187dd0234b653894d10d9b12c056a Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:50:49 +0100 Subject: [PATCH 09/16] Temporary rename for renamed method --- tests/Unit/AssetServiceUnitTest.php | 2 +- tests/Unit/BaseFoundationCollectionTest.php | 2 +- tests/Unit/BreadcrumbsComponentTest.php | 2 +- tests/Unit/BuildTaskUnitTest.php | 4 ++-- tests/Unit/HtmlTestingSupportMetaTest.php | 2 +- tests/Unit/NavItemTest.php | 2 +- tests/Unit/NavigationDataFactoryUnitTest.php | 2 +- tests/Unit/UnixsumTest.php | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/Unit/AssetServiceUnitTest.php b/tests/Unit/AssetServiceUnitTest.php index 9267b471..e9f4809b 100644 --- a/tests/Unit/AssetServiceUnitTest.php +++ b/tests/Unit/AssetServiceUnitTest.php @@ -17,7 +17,7 @@ class AssetServiceUnitTest extends UnitTestCase { protected function setUp(): void { - self::needsKernel(); + self::setupKernel(); self::mockConfig(); } diff --git a/tests/Unit/BaseFoundationCollectionTest.php b/tests/Unit/BaseFoundationCollectionTest.php index 9fb8edb7..0f11bb3b 100644 --- a/tests/Unit/BaseFoundationCollectionTest.php +++ b/tests/Unit/BaseFoundationCollectionTest.php @@ -17,7 +17,7 @@ class BaseFoundationCollectionTest extends UnitTestCase { public function testInit() { - $this->needsKernel(); + $this->setupKernel(); $booted = BaseFoundationCollectionTestClass::init(HydeKernel::getInstance())->boot(); diff --git a/tests/Unit/BreadcrumbsComponentTest.php b/tests/Unit/BreadcrumbsComponentTest.php index 154fddbf..e2553930 100644 --- a/tests/Unit/BreadcrumbsComponentTest.php +++ b/tests/Unit/BreadcrumbsComponentTest.php @@ -23,7 +23,7 @@ class BreadcrumbsComponentTest extends UnitTestCase { protected function setUp(): void { - self::needsKernel(); + self::setupKernel(); self::mockConfig(); } diff --git a/tests/Unit/BuildTaskUnitTest.php b/tests/Unit/BuildTaskUnitTest.php index 4b484cf2..be9aec94 100644 --- a/tests/Unit/BuildTaskUnitTest.php +++ b/tests/Unit/BuildTaskUnitTest.php @@ -153,7 +153,7 @@ public function testCanWriteToOutput() public function testCreatedSiteFile() { - self::needsKernel(); + self::setupKernel(); $task = new BufferedTestBuildTask(); @@ -164,7 +164,7 @@ public function testCreatedSiteFile() public function testCreatedSiteFileWithAbsolutePath() { - self::needsKernel(); + self::setupKernel(); $task = new BufferedTestBuildTask(); diff --git a/tests/Unit/HtmlTestingSupportMetaTest.php b/tests/Unit/HtmlTestingSupportMetaTest.php index 5b6ec6f4..491400cd 100644 --- a/tests/Unit/HtmlTestingSupportMetaTest.php +++ b/tests/Unit/HtmlTestingSupportMetaTest.php @@ -33,7 +33,7 @@ protected function setUp(): void { parent::setUp(); - self::needsKernel(); + self::setupKernel(); $this->html ??= file_get_contents(Hyde::vendorPath('resources/views/homepages/welcome.blade.php')); } diff --git a/tests/Unit/NavItemTest.php b/tests/Unit/NavItemTest.php index 379fbf58..6ce3d754 100644 --- a/tests/Unit/NavItemTest.php +++ b/tests/Unit/NavItemTest.php @@ -29,7 +29,7 @@ public static function setUpBeforeClass(): void { self::$hasSetUpKernel = false; - self::needsKernel(); + self::setupKernel(); self::mockConfig(); } diff --git a/tests/Unit/NavigationDataFactoryUnitTest.php b/tests/Unit/NavigationDataFactoryUnitTest.php index 8074f2ef..6833cacd 100644 --- a/tests/Unit/NavigationDataFactoryUnitTest.php +++ b/tests/Unit/NavigationDataFactoryUnitTest.php @@ -19,7 +19,7 @@ class NavigationDataFactoryUnitTest extends UnitTestCase { protected function setUp(): void { - self::needsKernel(); + self::setupKernel(); self::mockConfig(); } diff --git a/tests/Unit/UnixsumTest.php b/tests/Unit/UnixsumTest.php index 968c1d0d..0a001538 100644 --- a/tests/Unit/UnixsumTest.php +++ b/tests/Unit/UnixsumTest.php @@ -63,7 +63,7 @@ public function testMethodReturnsSameValueForStringWithMixedEndOfLineSequences() public function testMethodReturnsSameValueWhenLoadedFromFileUsingShorthand() { - self::needsKernel(); + self::setupKernel(); $string = "foo\nbar\r\nbaz\r\n"; From c164946001fd8e8268f38ddc9a7fdaaf4a453565 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 11:57:24 +0100 Subject: [PATCH 10/16] Update NavItemTest.php --- tests/Unit/NavItemTest.php | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/tests/Unit/NavItemTest.php b/tests/Unit/NavItemTest.php index 6ce3d754..19d5a6c4 100644 --- a/tests/Unit/NavItemTest.php +++ b/tests/Unit/NavItemTest.php @@ -25,14 +25,9 @@ */ class NavItemTest extends UnitTestCase { - public static function setUpBeforeClass(): void - { - self::$hasSetUpKernel = false; - - self::setupKernel(); - self::mockConfig(); - } - + protected static bool $needsKernel = true; + protected static bool $needsConfig = true; + protected function setUp(): void { Render::swap(new RenderData()); From 48bfa574e72a1704cb8bc7977ed23e5e63fdab57 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 12:05:40 +0100 Subject: [PATCH 11/16] Revert "Update NavItemTest.php" This reverts commit c164946001fd8e8268f38ddc9a7fdaaf4a453565. --- tests/Unit/NavItemTest.php | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/Unit/NavItemTest.php b/tests/Unit/NavItemTest.php index 19d5a6c4..6ce3d754 100644 --- a/tests/Unit/NavItemTest.php +++ b/tests/Unit/NavItemTest.php @@ -25,9 +25,14 @@ */ class NavItemTest extends UnitTestCase { - protected static bool $needsKernel = true; - protected static bool $needsConfig = true; - + public static function setUpBeforeClass(): void + { + self::$hasSetUpKernel = false; + + self::setupKernel(); + self::mockConfig(); + } + protected function setUp(): void { Render::swap(new RenderData()); From c93ce1f39ed0b3deb545fe42f30e19d64a3aa1ff Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 12:05:36 +0100 Subject: [PATCH 12/16] Delete phpunit.xml.dist --- tests/phpunit.xml.dist | 20 -------------------- 1 file changed, 20 deletions(-) delete mode 100644 tests/phpunit.xml.dist diff --git a/tests/phpunit.xml.dist b/tests/phpunit.xml.dist deleted file mode 100644 index 487a26f3..00000000 --- a/tests/phpunit.xml.dist +++ /dev/null @@ -1,20 +0,0 @@ - - - - - ./tests - ./packages/hyde/framework/tests - - - - - ./app - ./src - ./packages/hyde/framework/src - - - From f294aad94eacf525142bef5ddb3ab7bbac6b3d49 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 12:05:37 +0100 Subject: [PATCH 13/16] Update run-tests.yml --- .github/workflows/run-tests.yml | 37 ++++++++++++++------------------- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index b7a41f95..295a03a8 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -28,49 +28,44 @@ jobs: shell: bash run: | if [ "${{ github.ref }}" == "refs/heads/master" ]; then - git clone -b master https://github.com/hydephp/hyde.git + git clone -b master https://github.com/hydephp/develop.git runner else - git clone -b develop https://github.com/hydephp/hyde.git + git clone -b develop https://github.com/hydephp/develop.git runner fi - name: Copy over framework code shell: bash run: | - mkdir -p ./hyde/packages/hyde/framework/src - mkdir -p ./hyde/packages/hyde/framework/tests + rm -rf ./runner/packages/framework/src + rm -rf ./runner/packages/framework/tests + mkdir -p ./runner/packages/framework/src + mkdir -p ./runner/packages/framework/tests if [ "${{ matrix.os }}" == "windows-latest" ]; then # For Windows, copy to temp then back to preserve structure mkdir ../temp cp -r ./ ../temp - rm -rf ../temp/hyde - cp -r ../temp/src/. ./hyde/packages/hyde/framework/src - cp -r ../temp/tests/. ./hyde/packages/hyde/framework/tests + rm -rf ../temp/runner + cp -r ../temp/src/. ./runner/packages/framework/src + cp -r ../temp/tests/. ./runner/packages/framework/tests else # For Unix systems, use rsync - rsync -a --exclude=hyde ./src/. ./hyde/packages/hyde/framework/src - rsync -a --exclude=hyde ./tests/. ./hyde/packages/hyde/framework/tests + rsync -a --exclude=runner ./src/. ./runner/packages/framework/src + rsync -a --exclude=runner ./tests/. ./runner/packages/framework/tests fi - - name: Update composer.json to load framework from local source - run: | - cd hyde - composer config repositories.framework path ./packages/hyde/framework - composer require hyde/testing:dev-master hyde/framework:dev-develop - - - name: Move test runner configuration - shell: bash - run: cp tests/phpunit.xml.dist hyde/phpunit.xml.dist + - name: Install dependencies + run: cd runner && composer install - name: Set environment to testing - run: cd hyde && echo "ENV=testing" > .env + run: cd runner && echo "ENV=testing" > .env - name: Execute tests (Unit and Feature tests) via PHPUnit/Pest - run: cd hyde && vendor/bin/pest --log-junit report.xml + run: cd runner && vendor/bin/pest --log-junit report.xml env: ENV: testing - name: Ping statistics server with test results run: | - cd hyde + cd runner curl https://raw.githubusercontent.com/hydephp/develop/6e9d17f31879f4ccda13a3fec4029c9663bccec0/monorepo/scripts/ping-openanalytics-testrunner.php -o ping.php php ping.php "Framework CI Matrix" ${{ secrets.OPENANALYTICS_TOKEN }} From 67c7c6db9d4c3fc19eaa8b3ff891fa4754e2152d Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 12:07:15 +0100 Subject: [PATCH 14/16] Update run-tests.yml --- .github/workflows/run-tests.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 295a03a8..2eb645ab 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -26,12 +26,7 @@ jobs: - name: Install Hyde shell: bash - run: | - if [ "${{ github.ref }}" == "refs/heads/master" ]; then - git clone -b master https://github.com/hydephp/develop.git runner - else - git clone -b develop https://github.com/hydephp/develop.git runner - fi + run: git clone -b master https://github.com/hydephp/develop.git runner - name: Copy over framework code shell: bash From e5e827e3e7ac73ec360eda8dc4cad021b6653755 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 12:09:03 +0100 Subject: [PATCH 15/16] Update run-tests.yml --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 2eb645ab..c78208af 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -26,7 +26,7 @@ jobs: - name: Install Hyde shell: bash - run: git clone -b master https://github.com/hydephp/develop.git runner + run: git clone -b master https://github.com/hydephp/develop.git --depth 1 runner - name: Copy over framework code shell: bash From d50235b32a37bb64f6ddf62cf35bf58f9349f596 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Sat, 21 Dec 2024 12:09:06 +0100 Subject: [PATCH 16/16] Reapply "Update NavItemTest.php" This reverts commit 48bfa574e72a1704cb8bc7977ed23e5e63fdab57. --- tests/Unit/NavItemTest.php | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tests/Unit/NavItemTest.php b/tests/Unit/NavItemTest.php index 6ce3d754..94811a94 100644 --- a/tests/Unit/NavItemTest.php +++ b/tests/Unit/NavItemTest.php @@ -25,13 +25,8 @@ */ class NavItemTest extends UnitTestCase { - public static function setUpBeforeClass(): void - { - self::$hasSetUpKernel = false; - - self::setupKernel(); - self::mockConfig(); - } + protected static bool $needsKernel = true; + protected static bool $needsConfig = true; protected function setUp(): void {