From a5b3a9fc896e50c674949bb150e30d03523818a9 Mon Sep 17 00:00:00 2001
From: github-actions <github-actions@github.com>
Date: Wed, 10 Apr 2024 15:03:41 +0000
Subject: [PATCH] Merge pull request #1653 from hydephp/improve-test-suite

Internal: Improve test suite https://github.com/hydephp/develop/commit/bcd26e3d126daf9a50912e1ea4e6ac5370e5330c
---
 .../Feature/{ => Views}/MetadataViewTest.php  |  4 +-
 tests/Feature/Views/SidebarBrandViewTest.php  |  6 +--
 tests/Feature/{ => Views}/SidebarViewTest.php | 41 ++++---------------
 tests/Unit/BreadcrumbsComponentTest.php       | 12 +++---
 .../BreadcrumbsComponentViewTest.php          |  6 +--
 .../{Components => }/LinkComponentTest.php    |  6 +--
 6 files changed, 25 insertions(+), 50 deletions(-)
 rename tests/Feature/{ => Views}/MetadataViewTest.php (99%)
 rename tests/Feature/{ => Views}/SidebarViewTest.php (86%)
 rename tests/Unit/{ => Views}/BreadcrumbsComponentViewTest.php (99%)
 rename tests/Unit/Views/{Components => }/LinkComponentTest.php (94%)

diff --git a/tests/Feature/MetadataViewTest.php b/tests/Feature/Views/MetadataViewTest.php
similarity index 99%
rename from tests/Feature/MetadataViewTest.php
rename to tests/Feature/Views/MetadataViewTest.php
index 40d79186..19975964 100644
--- a/tests/Feature/MetadataViewTest.php
+++ b/tests/Feature/Views/MetadataViewTest.php
@@ -2,11 +2,11 @@
 
 declare(strict_types=1);
 
-namespace Hyde\Framework\Testing\Feature;
+namespace Hyde\Framework\Testing\Feature\Views;
 
-use Hyde\Foundation\HydeKernel;
 use Hyde\Hyde;
 use Hyde\Testing\TestCase;
+use Hyde\Foundation\HydeKernel;
 
 /**
  * This tests ensures all metadata is rendered correctly in the compiled pages.
diff --git a/tests/Feature/Views/SidebarBrandViewTest.php b/tests/Feature/Views/SidebarBrandViewTest.php
index 03670822..331f285e 100644
--- a/tests/Feature/Views/SidebarBrandViewTest.php
+++ b/tests/Feature/Views/SidebarBrandViewTest.php
@@ -5,8 +5,8 @@
 namespace Hyde\Framework\Testing\Feature\Views;
 
 use Hyde\Hyde;
+use Hyde\Facades\Features;
 use Hyde\Testing\TestCase;
-use Hyde\Foundation\HydeKernel;
 use Hyde\Testing\TestsBladeViews;
 use Hyde\Pages\DocumentationPage;
 
@@ -59,9 +59,7 @@ public function testSidebarBrandViewWithDefaultHeaderTextAndHomeRoute()
 
     public function testSidebarBrandViewWithoutDarkmodeFeature()
     {
-        $mock = $this->mock(HydeKernel::class)->makePartial();
-        $mock->shouldReceive('hasFeature')->with('darkmode')->andReturn(false);
-        HydeKernel::setInstance($mock);
+        Features::mock('darkmode', false);
 
         $view = $this->view(view('hyde::components.docs.sidebar-brand'));
 
diff --git a/tests/Feature/SidebarViewTest.php b/tests/Feature/Views/SidebarViewTest.php
similarity index 86%
rename from tests/Feature/SidebarViewTest.php
rename to tests/Feature/Views/SidebarViewTest.php
index 005b2421..9de8da87 100644
--- a/tests/Feature/SidebarViewTest.php
+++ b/tests/Feature/Views/SidebarViewTest.php
@@ -4,13 +4,12 @@
 
 declare(strict_types=1);
 
-namespace Hyde\Framework\Testing\Feature;
+namespace Hyde\Framework\Testing\Feature\Views;
 
-use Hyde\Framework\Features\Navigation\DocumentationSidebar;
-use Hyde\Hyde;
+use Throwable;
 use Hyde\Testing\TestCase;
 use Illuminate\Contracts\View\View;
-use Throwable;
+use Hyde\Framework\Features\Navigation\DocumentationSidebar;
 
 /**
  * Very high level test of the sidebar views and their combinations of layouts.
@@ -39,8 +38,7 @@ public function testBaseSidebar()
             ->assertSeeHtml('<a href="index.html">Back to home page</a>')
             ->assertSeeHtml('<span class="sr-only">Toggle dark theme</span>')
             ->assertDontSee('<a href="docs/index.html">')
-            ->assertDontSee('<li class="sidebar-item')
-            ->allGood();
+            ->assertDontSee('<li class="sidebar-item');
 
         $this->assertViewWasRendered(view('hyde::components.docs.sidebar-items', [
             'sidebar' => DocumentationSidebar::create(),
@@ -66,8 +64,7 @@ public function testBaseSidebarWithCustomFooterText()
         $this->renderComponent(view('hyde::components.docs.sidebar'))
             ->assertSeeHtml('<footer id="sidebar-footer"')
             ->assertSeeHtml('<p>My <strong>Markdown</strong> Footer Text</p>')
-            ->assertDontSee('Back to home page')
-            ->allGood();
+            ->assertDontSee('Back to home page');
     }
 
     public function testBaseSidebarCustomHeaderBrand()
@@ -76,8 +73,7 @@ public function testBaseSidebarCustomHeaderBrand()
 
         $this->renderComponent(view('hyde::components.docs.sidebar'))
             ->assertSeeText('My Custom Header')
-            ->assertDontSee('HydePHP Docs')
-            ->allGood();
+            ->assertDontSee('HydePHP Docs');
 
         $this->assertViewWasRendered(view('hyde::components.docs.sidebar-brand'));
     }
@@ -92,8 +88,7 @@ public function testBaseSidebarWithItems()
             ->assertSeeHtml('<a href="docs/index.html">')
             ->assertSeeHtml('<nav id="sidebar-navigation"')
             ->assertSeeHtml('<ul id="sidebar-items" role="list" class="pl-2">')
-            ->assertSeeHtml('<li class="sidebar-item')
-            ->allGood();
+            ->assertSeeHtml('<li class="sidebar-item');
 
         $this->assertViewWasRendered(view('hyde::components.docs.sidebar-items', [
             'sidebar' => DocumentationSidebar::create(),
@@ -120,8 +115,7 @@ public function testSidebarWithGroupedItems()
             ->assertSeeHtml('class="sidebar-group-toggle')
             ->assertSeeHtml('class="sidebar-group-toggle-icon')
             ->assertSeeHtml('class="sidebar-group-items')
-            ->assertSee('groupOpen')
-            ->allGood();
+            ->assertSee('groupOpen');
 
         $this->assertViewWasRendered(view('hyde::components.docs.sidebar-items', [
             'sidebar' => DocumentationSidebar::create(),
@@ -152,8 +146,7 @@ public function testSidebarWithNonCollapsibleGroupedItems()
             ->assertSeeHtml('class="sidebar-group-items')
             ->assertDontSee('sidebar-group-toggle')
             ->assertDontSee('sidebar-group-toggle-icon')
-            ->assertDontSee('groupOpen')
-            ->allGood();
+            ->assertDontSee('groupOpen');
 
         $this->assertViewWasRendered(view('hyde::components.docs.sidebar-items', [
             'sidebar' => DocumentationSidebar::create(),
@@ -167,16 +160,7 @@ protected function renderComponent(View $view): self
     {
         try {
             $this->html = $view->render();
-            /** @noinspection LaravelFunctionsInspection */
-            if (env('TEST_HTML_DEBUG', false)) {
-                file_put_contents(Hyde::path('_site/test.html'), $this->html);
-                echo "\e[0;32mCreated file: \e[0m".realpath(Hyde::path('_site/test.html'));
-            }
         } catch (Throwable $exception) {
-            /** @noinspection LaravelFunctionsInspection */
-            if (env('TEST_HTML_DEBUG', false)) {
-                throw $exception;
-            }
             $this->fail($exception->getMessage());
         }
 
@@ -226,11 +210,4 @@ protected function assertDontSee(string $text): self
 
         return $this;
     }
-
-    protected function allGood(): self
-    {
-        // Just an empty helper so we get easier Git diffs when adding new assertions.
-
-        return $this;
-    }
 }
diff --git a/tests/Unit/BreadcrumbsComponentTest.php b/tests/Unit/BreadcrumbsComponentTest.php
index c161d55b..154fddbf 100644
--- a/tests/Unit/BreadcrumbsComponentTest.php
+++ b/tests/Unit/BreadcrumbsComponentTest.php
@@ -4,20 +4,20 @@
 
 namespace Hyde\Framework\Testing\Unit;
 
-use Hyde\Framework\Views\Components\BreadcrumbsComponent;
+use Mockery;
+use Illuminate\View\Factory;
 use Hyde\Pages\MarkdownPage;
-use Hyde\Support\Facades\Render;
 use Hyde\Support\Models\Route;
 use Hyde\Testing\UnitTestCase;
-use Illuminate\Support\Facades\Facade;
+use Hyde\Support\Facades\Render;
 use Illuminate\Support\Facades\View;
-use Illuminate\View\Factory;
-use Mockery;
+use Illuminate\Support\Facades\Facade;
+use Hyde\Framework\Views\Components\BreadcrumbsComponent;
 
 /**
  * @covers \Hyde\Framework\Views\Components\BreadcrumbsComponent
  *
- * @see \Hyde\Framework\Testing\Unit\BreadcrumbsComponentViewTest
+ * @see \Hyde\Framework\Testing\Unit\Views\BreadcrumbsComponentViewTest
  */
 class BreadcrumbsComponentTest extends UnitTestCase
 {
diff --git a/tests/Unit/BreadcrumbsComponentViewTest.php b/tests/Unit/Views/BreadcrumbsComponentViewTest.php
similarity index 99%
rename from tests/Unit/BreadcrumbsComponentViewTest.php
rename to tests/Unit/Views/BreadcrumbsComponentViewTest.php
index 2b77225b..a434da46 100644
--- a/tests/Unit/BreadcrumbsComponentViewTest.php
+++ b/tests/Unit/Views/BreadcrumbsComponentViewTest.php
@@ -4,13 +4,13 @@
 
 declare(strict_types=1);
 
-namespace Hyde\Framework\Testing\Unit;
+namespace Hyde\Framework\Testing\Unit\Views;
 
-use Hyde\Framework\Views\Components\BreadcrumbsComponent;
+use Hyde\Testing\TestCase;
 use Hyde\Pages\MarkdownPage;
 use Hyde\Support\Facades\Render;
-use Hyde\Testing\TestCase;
 use Illuminate\Support\Facades\Blade;
+use Hyde\Framework\Views\Components\BreadcrumbsComponent;
 
 /**
  * @covers \Hyde\Framework\Views\Components\BreadcrumbsComponent
diff --git a/tests/Unit/Views/Components/LinkComponentTest.php b/tests/Unit/Views/LinkComponentTest.php
similarity index 94%
rename from tests/Unit/Views/Components/LinkComponentTest.php
rename to tests/Unit/Views/LinkComponentTest.php
index 7e5e667e..edcb4c15 100644
--- a/tests/Unit/Views/Components/LinkComponentTest.php
+++ b/tests/Unit/Views/LinkComponentTest.php
@@ -2,11 +2,11 @@
 
 declare(strict_types=1);
 
-namespace Hyde\Framework\Testing\Unit\Views\Components;
+namespace Hyde\Framework\Testing\Unit\Views;
 
-use Hyde\Foundation\Facades\Routes;
-use Hyde\Support\Facades\Render;
 use Hyde\Testing\TestCase;
+use Hyde\Support\Facades\Render;
+use Hyde\Foundation\Facades\Routes;
 use Illuminate\Support\Facades\Blade;
 
 /**