Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: the parser issuePrefixes still can't pass the references-empty rule test #23

Closed
KeidsID opened this issue Nov 13, 2024 · 0 comments

Comments

@KeidsID
Copy link

KeidsID commented Nov 13, 2024

Describe Your Issue?

I've seen the #22 PR. But the parser feature still can't pass the references-empty rule test.

Steps To Reproduce

  1. Follow the commintlint_cli setup documentation on your dart/flutter project.

  2. Make sure to use commintlint_cli v0.8.0 on pubspec.yaml.

    dev_dependencies:
      commitlint_cli: ^0.8.0
  3. Create the commitlint.yaml file on project root with the following content:

    # https://github.com/hyiso/commitlint/blob/main/lib/commitlint.yaml
    include: package:commitlint_cli/commitlint.yaml
    
    # https://github.com/hyiso/commitlint/pull/22
    parser:
      issuePrefixes:
        - "sv-"
    
    # https://hyiso.github.io/commitlint/#/references-rules
    rules:
      type-enum:
        - 2
        - always
        - - build
          - chore
          - docs
          - feat
          - fix
          - refactor
          - revert
          - style
          - test
      scope-enum:
        - 2
        - always
        - - domain
          - infrastructures
          - use_cases
          - interfaces
          - lib
          - root
      references-empty:
        - 2
        - never
  4. Try to commit with the following message:

    $ feat: add tv shows service sv-25
    $ fix: fix unresponsive movies page sv-250
    $ fix(root): fix commitlint config sv-1

Expected Result

The commitlint should pass the references-empty rule test.

Actual Result

The commitlint fails the references-empty rule test.

⧗  input: fix(root): fix commitlint config sv-1


✖  references must not be empty references-empty

✖  found 1 error(s), 0 warning(s)

Additional Screenshots/Videos

dart-commitlint_cli-reference_bug.mp4

Repo link

What OS are you using?

Windows 11 Home Single Language

What version of Dart/Flutter are you using?

Flutter v3.24.0 (stable) Windows.

@hyiso hyiso closed this as completed in 0651e59 Nov 13, 2024
hyiso added a commit that referenced this issue Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant