From b8c5ffd75f8402aa0fe13760e98fb4e97a1df875 Mon Sep 17 00:00:00 2001
From: Andrew <andrew@hypar.io>
Date: Sun, 28 Apr 2024 09:58:51 -0400
Subject: [PATCH 1/2] fix some bugs in the notebook viewer

---
 Elements/src/extension.dib | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Elements/src/extension.dib b/Elements/src/extension.dib
index 9a0e53d41..58b704052 100644
--- a/Elements/src/extension.dib
+++ b/Elements/src/extension.dib
@@ -25,7 +25,7 @@ using System;
 using System.IO;
 
 var viewerSrc = @"
-<div id=""main_DIV_ID"" style=""height:WIDTH_VAR;width:HEIGHT_VARpx;""></div>
+<div id=""main_DIV_ID"" style=""height:HEIGHT_VARpx;width:WIDTH_VARpx;""></div>
 </div>
 <script type=""module"">
 import * as THREE from 'https://unpkg.com/three@0.126.0/build/three.module.js';
@@ -92,10 +92,10 @@ const fitCameraToObject = function (scene, offset = 1.25) {
         camera.position.copy(center.clone().add(size.clone().multiplyScalar(offset)))
     }
 
-    const minZ = boundingBox.min.z;
+    const minZ = boundingBox.min.y;
     const cameraToFarEdge = (minZ < 0) ? -minZ + cameraZ : cameraZ - minZ;
 
-    camera.far = cameraToFarEdge * 10;
+    camera.far = cameraToFarEdge * 30;
     camera.updateProjectionMatrix();
 
     if (controls) {

From 58fa1a0e78405cf86ec9d4a9d75afd6fb53c7189 Mon Sep 17 00:00:00 2001
From: Andrew <andrew@hypar.io>
Date: Sun, 28 Apr 2024 10:18:16 -0400
Subject: [PATCH 2/2] direction-independent far plane calc

---
 Elements/src/extension.dib | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Elements/src/extension.dib b/Elements/src/extension.dib
index 58b704052..3f7344223 100644
--- a/Elements/src/extension.dib
+++ b/Elements/src/extension.dib
@@ -92,10 +92,9 @@ const fitCameraToObject = function (scene, offset = 1.25) {
         camera.position.copy(center.clone().add(size.clone().multiplyScalar(offset)))
     }
 
-    const minZ = boundingBox.min.y;
-    const cameraToFarEdge = (minZ < 0) ? -minZ + cameraZ : cameraZ - minZ;
+    const cameraToFarEdge = camera.position.distanceTo(center) + maxDim;
 
-    camera.far = cameraToFarEdge * 30;
+    camera.far = cameraToFarEdge * 5;
     camera.updateProjectionMatrix();
 
     if (controls) {