Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] Allowlists created with custom app aren't claimable #1287

Closed
bitbeckers opened this issue Mar 27, 2024 · 5 comments
Closed

[FE] Allowlists created with custom app aren't claimable #1287

bitbeckers opened this issue Mar 27, 2024 · 5 comments
Assignees
@bitbeckers

Comments

@bitbeckers
Copy link
Contributor

Which area(s) of Hypercerts are affected? (leave empty if unsure)

No response

To Reproduce

Multiple users reported not being able to claim from an allowlist

Describe the Bug

When claiming from an allowlist (GG19 certs in the users reports) the tx fails.

Expected Behavior

Users should be able to claim all fractions listed as claimable
@bitbeckers bitbeckers self-assigned this Mar 27, 2024
@bitbeckers
Copy link
Contributor Author

Was able to claim older claims: https://optimistic.etherscan.io/tx/0x5f228d54d6eff97e632951ab8ede7ae95fb3e60b96cabef52c856f91ad134e29

Issue appears to be with newly created allowlists from a custom app

@bitbeckers
Copy link
Contributor Author

bitbeckers commented Mar 27, 2024 •
edited
Loading

Able to batch claim certs on OP: https://optimistic.etherscan.io/tx/0xd30d918b154138e733281f8fb75ae3154f64db47e7605578c0e250fc1494c11b

@bitbeckers
Copy link
Contributor Author

bitbeckers commented Mar 27, 2024 •
edited
Loading

Application sends empty claim tx: https://optimistic.etherscan.io/tx/0xef2d0d9226b432885cd12ec3fdcda5a8d93e7374f9703fa87664fd93f7041371

From minter logs:
Screenshot 2024-03-27 at 13 51 19

@bitbeckers
Copy link
Contributor Author

Successful claim from localhost: https://optimistic.etherscan.io/tx/0x0b185603fbe42dfffc9ad887ec3f4ebf737bd2a37616d81e823aa4c829fd5bc4

Issue turns out to be address matching in during proof fetching. Lo 👏 wer 👏 case 👏

@bitbeckers bitbeckers linked a pull request Mar 27, 2024 that will close this issue
fix(lowercase): compare addresses lowercased #1289
Closed
@bitbeckers
Copy link
Contributor Author

Verified with one of the original reporters of the issues that it's solved: https://discord.com/channels/1075404472152494100/1216835678034198528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitbeckers bitbeckers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lowercase): compare addresses lowercased hypercerts-org/hypercerts
1 participant
@bitbeckers