Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of "active" and "lastItem" in Nav.stories.js #46

Open
noteed opened this issue Dec 29, 2019 · 1 comment
Open

Usage of "active" and "lastItem" in Nav.stories.js #46

noteed opened this issue Dec 29, 2019 · 1 comment

Comments

@noteed
Copy link
Member

noteed commented Dec 29, 2019

In Nav.stories.js, the first example has "active" and the second one has "lastItem". Would it be ok to add both properties to both example ?

If it's ok, I'll do it, I already have a branch renaming that file to Navigation.stories.js.

@andyngo
Copy link
Contributor

andyngo commented Dec 30, 2019

Yes for adding active and lastItem for both examples!

For the first example, lastItem is not really required but for consistency it would be better to add it.
For active, I agree both examples should have this. Thanks for catching this.

If you push your branch I can help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants