Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ethers-rs): fee escalation improvements #34

Closed
wants to merge 29 commits into from
Closed

fix(ethers-rs): fee escalation improvements #34

wants to merge 29 commits into from

Conversation

aroralanuk
Copy link

@aroralanuk aroralanuk commented Feb 17, 2025 •
edited
Loading

Motivation

@christianangelopoulos spotted us overpaying priority fees on low-cost chains because of the default minimum of 0.1 gwei.

Looking deeper into this, there's some hardcoded/unnecessary logic that doesn't suit our needs well for transaction submission on EVM chains.

Solution

Idea is to make it estimate closer to that in alloy/metamask:

  • @christianangelopoulos set the EIP1559_FEE_ESTIMATION_DEFAULT_PRIORITY_FEE to 1wei if say the rewards isn't provided (bc 0 may be problematic for some chains)
  • @christianangelopoulos set base_fee as 2 x last block base fee (conservative compared to metamask's 1.25x for fast mode)
  • max_fee is now unconditionally priority_fee + base_fee (to not starve off base_fee)
  • updated the base_fee to always be non-zero
  • remove outlier rejection from median calculation (median is robust to outliers)
  • 1.2x multipler for median priority fee (conservative compared to metamask which used 0.97x even for fast mode)

Tests

Unit

Note: failing tests are etherscan API related, not relevant for this PR.

0xMelkor and others added 26 commits November 28, 2022 12:16
@0xMelkor @mattsse
Feat middleware stack builder (gakonst#1890)
16ab3d5 
* ProviderBuilder struct + docs

* README

* Docs typos

* Removed useless Arc
Rename module

* Unit tests

* cargo +nightly fmt

* CHANGELOG

* CHANGELOG typo

* ci: fix docs job

* review: Removed Option<M>. Builder functions directly consume self.

* feat: `with_signer` builder function

* feat: `nonce_manager` builder function

* feat: `gas_oracle` builder function

* Unit tests

* Docs

* fix: cargo +nightly fmt

* Update ethers-middleware/src/builder.rs

Typo

Co-authored-by: Matthias Seitz <[email protected]>

* Builder functions provided as a trait
Update docs
Update tests

* cargo +nightly fmt

* CHANGELOG

Co-authored-by: Andrea Simeoni <>
Co-authored-by: Matthias Seitz <[email protected]>
@dependabot
chore(deps): bump syn from 1.0.103 to 1.0.104 (gakonst#1901)
4d5e032 
Bumps [syn](https://github.com/dtolnay/syn) from 1.0.103 to 1.0.104.
- [Release notes](https://github.com/dtolnay/syn/releases)
- [Commits](dtolnay/syn@1.0.103...1.0.104)

---
updated-dependencies:
- dependency-name: syn
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump chrono from 0.4.20 to 0.4.23 (gakonst#1900)
79e64a8 
Bumps [chrono](https://github.com/chronotope/chrono) from 0.4.20 to 0.4.23.
- [Release notes](https://github.com/chronotope/chrono/releases)
- [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md)
- [Commits](chronotope/chrono@v0.4.20...v0.4.23)

---
updated-dependencies:
- dependency-name: chrono
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mattsse
feat(provider): check for serde error with missing req id (gakonst#1910)
d48187a
@6m-e @DaniPopes
fix: txpool_inspect unable to parse contract creations (gakonst#1905)
82f19e0 
* Fixes gakonst#1899

* replace match with if let some() else

* fix error: number too large to fit in target type

* Apply suggestions from code review

Co-authored-by: DaniPopes <[email protected]>

Co-authored-by: DaniPopes <[email protected]>
@mattsse
fix(abigen): rm wrong brackets (gakonst#1914)
17addcf
@DaniPopes
feat(core): Chain impls and refactoring (gakonst#1909)
866d305 
* sort

* derive Default

* use u64 for conversions and add impl

* one impl block and comments
@dependabot
chore(deps): bump tokio-tungstenite from 0.17.2 to 0.18.0 (gakonst#1908)
bbe53bf 
Bumps [tokio-tungstenite](https://github.com/snapview/tokio-tungstenite) from 0.17.2 to 0.18.0.
- [Release notes](https://github.com/snapview/tokio-tungstenite/releases)
- [Changelog](https://github.com/snapview/tokio-tungstenite/blob/master/CHANGELOG.md)
- [Commits](snapview/tokio-tungstenite@v0.17.2...v0.18.0)

---
updated-dependencies:
- dependency-name: tokio-tungstenite
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@DaniPopes
fix(contract): multicall decode error (gakonst#1907)
2d793ed 
* wip

* use empty bytes for reverts

* minor improvements

* fix test

* use is_empty

* docs

* clippy

* fix: rust-analyzer bug

* revert rename
@Rjected @gakonst
feat(providers): add a subset of admin namespace (gakonst#1880)
4b68562 
* tell Geth to expose the admin namespace

* wip: add admin namespace support

 * add networking and peer related structs

* add rest of chain config fields

* add datadir to geth

* fix data dir ref

* add dev flag to geth

* set dev only if block_time is not set

* put mutually exclusive options in an enum

* make block_time use the devmode enum

* add p2p port to geth

* add basic impls for admin endpoints

* move from_int_or_hex to ethers-core utils

* fix nodeinfo protocol field

 * the type is better represented by a struct which can have either eth
   or snap

* add chain id and discovery toggle for Geth

* remove PeerEvent

 * should re-add when peer event endpoints are implemented

* simplify serde options for admin responses

* change signature for peer modification apis

 * these admin apis accept an enode, which _may_ be an enr, but could
   also be a legacy enode "v4" url.

* add note on where `ChainConfig` fields come from

* add note on PeerInfo about the source of fields

* add admin namespace support to CHANGELOG

* update pr number in changelog

* cargo fmt

* move chainconfig to genesis in utils

* accept genesis file in geth

* add genesis writing to geth spawn

* finally get geth nodes to connect

* import io::Read in provider tests

* fix PeerInfo and use enode id for provider test

* make clippy happy

* improve documentation for genesis module

* remove not(wasm) attributes on genesis module

* remove debugging printlns

* remove io::Read from provider tests

* add failing post merge test case

* add full mainnet nodeinfo for testing

* support deserializing json bignums to U256

 * the serde_json arbitrary_precision feature is necessary so the
   serde_json::Number variant of `IntOrHexOrBigNum` can be converted
   into a string and fed into U256::from_dec_string

* fix from_int_or_hex_opt doc string

* remove third variant from IntOrHex

 * unnecessary since serde_json::Number handles smaller ints as well

* add comments for ids

* fix enode id type in admin_peers provider test

* fix admin typo in Cargo.toml

Co-authored-by: Georgios Konstantopoulos <[email protected]>

* add method to wait on a gethinstance adding a peer

* fix dial loop and wait_to_add_peer doc comments

* update geth

 * the build can be updated by changing the GETH_BUILD env var

* wait for geth to exit on drop

* remove unnecessary wait

* fix mid-handshake PeerInfo deserialization

* remove println

* make tests less flaky

* handle discovery with the rest of the non dev opts

* dump geth stderr to debug failing ci test

 * add method which dumps the unread stderr of the geth instance into a
   string

* remove call_raw debug println

 * bug is due to authrpc endpoint being in use

* use unused port when authrpc port is not specified

* remove dump_stderr from GethInstance

 * did not work properly anyways

Co-authored-by: Georgios Konstantopoulos <[email protected]>
@mattsse
fix: make version detection infallible (gakonst#1916)
0ce6b10
@0xMelkor
Fix: handle panic on Ws error (gakonst#1915)
c4e09f2 
* On Ws error close all active subscriptions and force clients to reconnect. the Websocket.

* Comment typos

* Unit tests
Lint
cargo +nightly fmt

* - Added CHANGELOG entry
- Added `#` prefix to issue IDs where missing

* ownership typo

Co-authored-by: Andrea Simeoni <>
@Rjected
fix(core): always set p2p port in non-dev mode (gakonst#1919)
5af2800 
* if geth is in non-dev mode, it has been explicitly set by either
   disabling discovery or setting a p2p port. To prevent geth from
   crashing if another process is using the default p2p port, always set
   the p2p port if geth is in non-dev mode.
@prestwich
feature: providererror conversion to middleware error (gakonst#1920)
d6fea13 
* feature: providererror conversion to middleware error

* chore: update changelog
@odyslam
feat: impl Serialize for Chain (gakonst#1917)
3bf9025 
* feat: impl Serialize for Chain

* fix: add deps
@dependabot
chore(deps): bump syn from 1.0.104 to 1.0.105 (gakonst#1918)
4e98c4a 
Bumps [syn](https://github.com/dtolnay/syn) from 1.0.104 to 1.0.105.
- [Release notes](https://github.com/dtolnay/syn/releases)
- [Commits](dtolnay/syn@1.0.104...1.0.105)

---
updated-dependencies:
- dependency-name: syn
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@6m-e @gakonst
fix: remove OpCode enum and update VMOperation's op field type (g…
913f15d 
…akonst#1904)

* remove OpCode enum and update VMOperation's op field

* restore opcodes + update 0x20 to keccak256

* enum to deserialize opcodes into known or unknown

* Update ethers-core/src/types/trace/mod.rs

Co-authored-by: Georgios Konstantopoulos <[email protected]>

* fix typo: ExecutedInstruction

Co-authored-by: Georgios Konstantopoulos <[email protected]>
@0xMelkor
Docs: Middleware library (gakonst#1912)
e5aa451 
* Updated the middleware README heading

* fix docs CI

* Added heading description for the main middlewares

* Restructure README examples

* Fix docs CI

* Fix MiddlewareBuilder function docs

* Typos inside the middleware README

Co-authored-by: Andrea Simeoni <>
@mattsse
feat: add infura error code to retry detection (gakonst#1921)
f886d37
@jatkz
refac: change awsSigner to own kmsclient (gakonst#1922)
a88d2d0
@christianangelopoulos
rework priority fee logic
83fef11
@christianangelopoulos
PR 33 feedback
e62719c
@christianangelopoulos
fixed tests
ea7f3f1
@aroralanuk
simplify median calculations
b4d41e6
@aroralanuk
Merge branch 'master' into kunal/fees-estimation-improvements
df8685b
@aroralanuk
cargo.lock
5ff04b5
@aroralanuk aroralanuk changed the base branch from master to hyperlane February 18, 2025 11:16
@aroralanuk aroralanuk marked this pull request as ready for review February 18, 2025 14:00
@aroralanuk aroralanuk closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aroralanuk @0xMelkor @mattsse @6m-e @DaniPopes @Rjected @prestwich @odyslam @jatkz @christianangelopoulos