Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename wallet.Backend.RandomWallet -> RandomizerWallet #236

Open
matthiasgeihs opened this issue Oct 7, 2021 · 0 comments
Open

Rename wallet.Backend.RandomWallet -> RandomizerWallet #236

matthiasgeihs opened this issue Oct 7, 2021 · 0 comments
Labels
refactor No logic but only implementation changes.
Milestone
Beautification

Comments

@matthiasgeihs
Copy link
Contributor

Location

wallet/backend.go

Problem

The method RandomWallet returns a fixed wallet, but sounds like it would return a new random wallet every time it is called.

Proposal

Rename the method to RandomizerWallet, as it returns the wallet of the randomizer.
@ggwpez ggwpez added this to the Beautification milestone Oct 14, 2021
@ggwpez ggwpez added the refactor No logic but only implementation changes. label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor No logic but only implementation changes.
Projects
None yet
Milestone
Beautification
Development

No branches or pull requests
2 participants
@ggwpez @matthiasgeihs