TransactionResult: add v for blob and pending tx (#8196)

* add v for blob and pending tx Signed-off-by: Sally MacFarlane <[email protected]> * add v for blob and pending tx in tests Signed-off-by: Sally MacFarlane <[email protected]> * add v for blob tx in test Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>
hyperledger · Jan 30, 2025 · 5ac3247 · 5ac3247
1 parent 6af23ea
commit 5ac3247
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 3 deletions.
diff --git a/...st/resources/jsonrpc/engine/cancun/test-cases/block-production/02_cancun_get_blob_tx.json b/...st/resources/jsonrpc/engine/cancun/test-cases/block-production/02_cancun_get_blob_tx.json
diff --git a/...org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/TransactionCompleteResult.java b/...org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/TransactionCompleteResult.java
@@ -130,8 +130,9 @@ public TransactionCompleteResult(final TransactionWithMetadata tx) {
       this.yParity = Quantity.create(transaction.getYParity());
       this.v =
           (transactionType == TransactionType.ACCESS_LIST
-                      || transactionType == TransactionType.EIP1559)
+                  || transactionType == TransactionType.EIP1559
                   || transactionType == TransactionType.DELEGATE_CODE
+                  || transactionType == TransactionType.BLOB)
               ? Quantity.create(transaction.getYParity())
               : null;
     }

diff --git a/.../org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/TransactionPendingResult.java b/.../org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/TransactionPendingResult.java
@@ -115,7 +115,9 @@ public TransactionPendingResult(final Transaction transaction) {
       this.yParity = Quantity.create(transaction.getYParity());
       this.v =
           (transactionType == TransactionType.ACCESS_LIST
-                  || transactionType == TransactionType.EIP1559)
+                  || transactionType == TransactionType.EIP1559
+                  || transactionType == TransactionType.DELEGATE_CODE
+                  || transactionType == TransactionType.BLOB)
               ? Quantity.create(transaction.getYParity())
               : null;
     }

diff --git a/...s/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getBlockByNumber_complete_cancun.json b/...s/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getBlockByNumber_complete_cancun.json
@@ -52,6 +52,7 @@
           "type": "0x3",
           "value": "0x0",
           "yParity": "0x0",
+          "v" : "0x0",
           "r": "0x6ae0612cfda43a9b464b10b4881c6fc2e4c24533cf89bbe07934da65c3ae49ce",
           "s": "0x125387aeb222ec51130cf99cbdabf24bd4a881914faed69f254e4a3f4bc507fc",
           "blobVersionedHashes": [

diff --git a/...rledger/besu/ethereum/api/jsonrpc/eth/eth_getTransactionByBlockNumberAndIndex_latest.json b/...rledger/besu/ethereum/api/jsonrpc/eth/eth_getTransactionByBlockNumberAndIndex_latest.json
@@ -30,6 +30,7 @@
       "type": "0x3",
       "value": "0x0",
       "yParity": "0x0",
+      "v" : "0x0",
       "r": "0x6ae0612cfda43a9b464b10b4881c6fc2e4c24533cf89bbe07934da65c3ae49ce",
       "s": "0x125387aeb222ec51130cf99cbdabf24bd4a881914faed69f254e4a3f4bc507fc",
       "blobVersionedHashes": [

diff --git a/...ledger/besu/ethereum/api/jsonrpc/eth/eth_getTransactionByBlockNumberAndIndex_pending.json b/...ledger/besu/ethereum/api/jsonrpc/eth/eth_getTransactionByBlockNumberAndIndex_pending.json
@@ -30,6 +30,7 @@
       "type": "0x3",
       "value": "0x0",
       "yParity": "0x0",
+      "v" : "0x0",
       "r": "0x6ae0612cfda43a9b464b10b4881c6fc2e4c24533cf89bbe07934da65c3ae49ce",
       "s": "0x125387aeb222ec51130cf99cbdabf24bd4a881914faed69f254e4a3f4bc507fc",
       "blobVersionedHashes": [