From a3f4802ac815da7511974c77366ef1a38f22f448 Mon Sep 17 00:00:00 2001
From: Alejandro Celaya <alejandro.celaya@hypothes.is>
Date: Tue, 20 Feb 2024 11:21:08 +0100
Subject: [PATCH] Add accessible names to profile and notebook dialogs

---
 src/annotator/components/ModalDialog.tsx   | 3 +++
 src/annotator/components/NotebookModal.tsx | 3 ++-
 src/annotator/components/ProfileModal.tsx  | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/annotator/components/ModalDialog.tsx b/src/annotator/components/ModalDialog.tsx
index 54903347542..12c0171acac 100644
--- a/src/annotator/components/ModalDialog.tsx
+++ b/src/annotator/components/ModalDialog.tsx
@@ -7,6 +7,7 @@ type DialogProps = {
   children: ComponentChildren;
   onClose: () => void;
   'data-testid'?: string;
+  'aria-label'?: string;
 };
 
 function NativeDialog({
@@ -14,6 +15,7 @@ function NativeDialog({
   onClose,
   children,
   'data-testid': testId,
+  'aria-label': label,
 }: DialogProps) {
   const dialogRef = useRef<HTMLDialogElement | null>(null);
 
@@ -39,6 +41,7 @@ function NativeDialog({
       ref={dialogRef}
       className="relative w-full h-full backdrop:bg-black/50"
       data-testid={testId}
+      aria-label={label}
     >
       {children}
     </dialog>
diff --git a/src/annotator/components/NotebookModal.tsx b/src/annotator/components/NotebookModal.tsx
index 604e80fcb60..b9c3a69ef44 100644
--- a/src/annotator/components/NotebookModal.tsx
+++ b/src/annotator/components/NotebookModal.tsx
@@ -112,10 +112,11 @@ export default function NotebookModal({
       closed={isHidden}
       onClose={onClose}
       data-testid="notebook-outer"
+      aria-label="Hypothesis notebook"
     >
       <div className="absolute right-0 m-3">
         <IconButton
-          title="Close the Notebook"
+          title="Close notebook"
           onClick={onClose}
           variant="dark"
           classes={classnames(
diff --git a/src/annotator/components/ProfileModal.tsx b/src/annotator/components/ProfileModal.tsx
index d262dcd1636..65912db94b7 100644
--- a/src/annotator/components/ProfileModal.tsx
+++ b/src/annotator/components/ProfileModal.tsx
@@ -42,6 +42,7 @@ export default function ProfileModal({ eventBus, config }: ProfileModalProps) {
       closed={isHidden}
       onClose={onClose}
       data-testid="profile-outer"
+      aria-label="Hypothesis profile"
     >
       <div className="absolute right-0 m-3">
         <IconButton