Add missing type attribute to clipboard copy buttons

This fixes an issue where clicking the "Copy to clipboard" button for the group invite links would trigger a page reload.
hypothesis · Nov 22, 2024 · 74181b0 · 74181b0
1 parent 2ca0928
commit 74181b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/h/templates/activity/search.html.jinja2 b/h/templates/activity/search.html.jinja2
@@ -298,7 +298,8 @@
                value="{{ group.url }}">
         <button class="group-invite__clipboard-button"
                 data-ref="button"
-                title="Copy to clipboard">
+                title="Copy to clipboard"
+                type="button">
           {{ svg_icon('copy_to_clipboard', 'group-invite__clipboard-image') }}
         </button>
       </div>

diff --git a/h/templates/includes/share_widget.html.jinja2 b/h/templates/includes/share_widget.html.jinja2
@@ -29,7 +29,8 @@
              readonly>
       <button class="share-widget-link__btn"
               data-ref="button"
-              title="Copy to clipboard">
+              title="Copy to clipboard"
+              type="button">
         {{ svg_icon('copy_to_clipboard', 'share-widget-link__btn--copy share-widget-action') }}
       </button>
   </div>