Skip to content

Commit

Permalink
Use singular for each of the query parameters for list filters
Browse files Browse the repository at this point in the history
  • Loading branch information
marcospri committed Jul 11, 2024
1 parent a243246 commit 24ebdcb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions lms/views/dashboard/api/course.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ class CoursesMetricsSchema(PyramidRequestSchema):

location = "querystring"

h_userids = fields.List(fields.Str())
h_userids = fields.List(fields.Str(), data_key="h_userid")
"""Return metrics for these users only."""

assignment_ids = fields.List(fields.Integer())
assignment_ids = fields.List(fields.Integer(), data_key="assignment_id")
"""Return metrics for these assignments only."""

courses_ids = fields.List(fields.Integer())
courses_ids = fields.List(fields.Integer(), data_key="course_id")
"""Return metrics for these courses only."""


Expand Down
2 changes: 1 addition & 1 deletion lms/views/dashboard/api/user.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class UsersMetricsSchema(PyramidRequestSchema):
assignment_id = fields.Integer(required=True, validate=validate.Range(min=1))
"""Return users that belong to the assignment with this ID."""

h_userids = fields.List(fields.Str())
h_userids = fields.List(fields.Str(), data_key="h_userid")
"""Return metrics for these users only."""


Expand Down

0 comments on commit 24ebdcb

Please sign in to comment.