Skip to content

Commit

Permalink
Don't use Course.copied_from_id for LMSCourse equivalent
Browse files Browse the repository at this point in the history
We need the FK on the LMSCourse table itself, not the old table.

However we can't yet get that value until we backfill the table
complete to get a reference for all row in the new table.
  • Loading branch information
marcospri committed Aug 26, 2024
1 parent 555b869 commit 8f009ee
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion lms/services/course.py
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ def _upsert_lms_course(self, course: Course) -> LMSCourse:
"tool_consumer_instance_guid": course.application_instance.tool_consumer_instance_guid,
"lti_context_id": course.lms_id,
"h_authority_provided_id": course.authority_provided_id,
"copied_from_id": course.copied_from_id,
"name": course.lms_name,
}
],
Expand Down
1 change: 0 additions & 1 deletion tests/unit/lms/services/course_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ def test_upsert_course(self, svc, grouping_service, bulk_upsert, db_session):
"tool_consumer_instance_guid": course.application_instance.tool_consumer_instance_guid,
"lti_context_id": course.lms_id,
"h_authority_provided_id": course.authority_provided_id,
"copied_from_id": course.copied_from_id,
"name": course.lms_name,
}
],
Expand Down

0 comments on commit 8f009ee

Please sign in to comment.