From b4d92d10c078ee6a2185bd33dd712b838be21322 Mon Sep 17 00:00:00 2001 From: Robert Knight Date: Tue, 12 Mar 2024 11:53:26 +0000 Subject: [PATCH] Prefer `T | None` over `Optional[T]` This follows the style guide at https://typing.readthedocs.io/en/latest/source/best_practices.html#shorthand-syntax. --- lms/services/canvas_studio.py | 4 ++-- lms/services/exceptions.py | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lms/services/canvas_studio.py b/lms/services/canvas_studio.py index 4e8671f4ac..ed13e8d862 100644 --- a/lms/services/canvas_studio.py +++ b/lms/services/canvas_studio.py @@ -1,4 +1,4 @@ -from typing import Literal, Optional, TypedDict +from typing import Literal, TypedDict from urllib.parse import urlencode, urlunparse from marshmallow import EXCLUDE, Schema, fields, post_load @@ -61,7 +61,7 @@ class File(TypedDict): display_name: str updated_at: str - contents: Optional[APICallInfo] + contents: APICallInfo | None """API call to use to fetch contents of a folder.""" diff --git a/lms/services/exceptions.py b/lms/services/exceptions.py index c9c64acf0c..4cede9a891 100644 --- a/lms/services/exceptions.py +++ b/lms/services/exceptions.py @@ -1,5 +1,3 @@ -from typing import Optional - from lms.models.oauth2_token import Service @@ -48,8 +46,8 @@ def __init__( response=None, validation_errors=None, refreshable=False, - refresh_route: Optional[str] = None, - refresh_service: Optional[Service] = None, + refresh_route: str | None = None, + refresh_service: Service | None = None, ): # pylint: disable=too-many-arguments super().__init__() self.message = message