From c25d8b31ee3bb96d559259bf9bc8fb6296cef561 Mon Sep 17 00:00:00 2001 From: Alejandro Celaya Date: Tue, 10 Sep 2024 14:56:00 +0200 Subject: [PATCH] Update button to clear dashboard filters (#6663) --- .../dashboard/DashboardActivityFilters.tsx | 16 +++++++++------- package.json | 2 +- yarn.lock | 10 +++++----- 3 files changed, 15 insertions(+), 13 deletions(-) diff --git a/lms/static/scripts/frontend_apps/components/dashboard/DashboardActivityFilters.tsx b/lms/static/scripts/frontend_apps/components/dashboard/DashboardActivityFilters.tsx index 1865e32f05..9a7e4439df 100644 --- a/lms/static/scripts/frontend_apps/components/dashboard/DashboardActivityFilters.tsx +++ b/lms/static/scripts/frontend_apps/components/dashboard/DashboardActivityFilters.tsx @@ -1,7 +1,7 @@ import { Button, - CancelIcon, - IconButton, + FilterClearIcon, + LinkButton, MultiSelect, RefreshIcon, } from '@hypothesis/frontend-shared'; @@ -435,13 +435,15 @@ export default function DashboardActivityFilters({ )} /> {hasSelection && onClearSelection && ( - onClearSelection()} data-testid="clear-button" - /> + > + + Clear filters + )} ); diff --git a/package.json b/package.json index dc39a5963f..b6a5be6bdd 100644 --- a/package.json +++ b/package.json @@ -26,7 +26,7 @@ "@babel/preset-react": "^7.24.7", "@babel/preset-typescript": "^7.24.7", "@hypothesis/frontend-build": "^3.0.0", - "@hypothesis/frontend-shared": "^8.4.3", + "@hypothesis/frontend-shared": "^8.5.0", "@rollup/plugin-babel": "^6.0.4", "@rollup/plugin-commonjs": "^26.0.1", "@rollup/plugin-node-resolve": "^15.2.3", diff --git a/yarn.lock b/yarn.lock index eaf9c621fc..1ef37a1598 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2169,15 +2169,15 @@ __metadata: languageName: node linkType: hard -"@hypothesis/frontend-shared@npm:^8.4.3": - version: 8.4.3 - resolution: "@hypothesis/frontend-shared@npm:8.4.3" +"@hypothesis/frontend-shared@npm:^8.5.0": + version: 8.5.0 + resolution: "@hypothesis/frontend-shared@npm:8.5.0" dependencies: highlight.js: ^11.6.0 wouter-preact: ^3.0.0 peerDependencies: preact: ^10.4.0 - checksum: 78a7951f8acd9cb8aa67f4b34b175db558d47933d1db93b4bd63e857ef17fa966a55d29ed1668008212150d63d192f84f8a1213c50b5c6a881fee97c71c00bb6 + checksum: 4d01b2f07dc44173351e3e72f9607b54596468d620a0f872fe851776ad5c77dce5ec631fdfe77654c6851f9a24a3701a5bbf0df78bf4ceff580ace73a86bd91a languageName: node linkType: hard @@ -7450,7 +7450,7 @@ __metadata: "@babel/preset-react": ^7.24.7 "@babel/preset-typescript": ^7.24.7 "@hypothesis/frontend-build": ^3.0.0 - "@hypothesis/frontend-shared": ^8.4.3 + "@hypothesis/frontend-shared": ^8.5.0 "@hypothesis/frontend-testing": ^1.2.2 "@rollup/plugin-babel": ^6.0.4 "@rollup/plugin-commonjs": ^26.0.1