Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid dashboard IDs in the query string (FE) #6537

Open
acelaya opened this issue Aug 8, 2024 · 1 comment
Open

Handle invalid dashboard IDs in the query string (FE) #6537

acelaya opened this issue Aug 8, 2024 · 1 comment
Assignees
Labels
Dashboard Issues related to instructor dashboards

Comments

@acelaya
Copy link
Contributor

acelaya commented Aug 8, 2024

Up until now we have not validated the selected courses, assignments and students that are represented in the URL query.

This means we will be showing "4 students" if the student_id query param appears 4 times, but if those are invalid values, the listbox might show a different amount of selected items.

This is even trickier to achieve with pagination in mind, as it is possible there are valid IDs in the query which are not part of the already loaded pages.

@acelaya acelaya added the Dashboard Issues related to instructor dashboards label Aug 8, 2024
@acelaya acelaya changed the title Handle invalid dashboard IDs in the query string Handle invalid dashboard IDs in the query string (FE) Aug 8, 2024
@acelaya acelaya self-assigned this Aug 8, 2024
@robertknight
Copy link
Member

In #6540 (comment) I identified an easy way to end up with "invalid" IDs in the query string just by clicking around our existing interface.

In the "All courses view":

  1. Select two assignments from different courses
  2. Navigate into one of the courses

Following the change in #6540, the two assignments remain in the selection, but only one of them exists in the new view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Issues related to instructor dashboards
Projects
None yet
Development

No branches or pull requests

2 participants