Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do your first code review #88

Closed
5 tasks done
seanh opened this issue Nov 8, 2024 · 0 comments
Closed
5 tasks done

Do your first code review #88

seanh opened this issue Nov 8, 2024 · 0 comments
Assignees

Comments

@seanh
Copy link
Contributor

seanh commented Nov 8, 2024

In this phase of your onboarding you'll start reviewing pull requests (PRs) from other developers.
Your buddy will help you identify some good first PRs to review.

  • Buddy: identify some good first PRs and assign them to the new engineer to review.

  • Engineer: re-read our Engineering Values.
    They describe the kinds of PRs that we want and how we want you to approach code review.

  • Engineer: read our code review guidelines.
    These go into more detail about how we do code review.

  • Engineer: check out the pull request branch locally and test it.
    The PR should contain testing instructions. If not, you can request them from the PR's author.

  • Engineer: check off this item once you've approved your first PR.
    In most cases, it is the author's responsibility to merge and deploy a PR once it has been approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants