Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Bouncer does not detect the Chrome extension it defaults to Via even if Hypothesis is embedded on the page #151

Open
mkdir-washington-edu opened this issue Oct 15, 2020 · 1 comment

Comments

@mkdir-washington-edu
Copy link
Contributor

Describe the bug
When bouncer is directed to a page where Hypothesis is embedded it treats it as if it were any other page; if checks for the Chrome extension and if it is not found it opens Via. But there are pages with Hypothesis embedded that rely on cookies or do not work in Via, and users of those pages can not link to annotations on those pages if they are not running Chrome.

To Reproduce
Steps to reproduce the behavior:

  1. Open https://press.rebus.community/openamlit/chapter/edgar-allan-poe/
  2. Note how Hypothesis is embedded
  3. In a browser without the Chrome extension open this link: https://hyp.is/-stKwuY7Eeq-AuMNi82WHw/press.rebus.community/openamlit/chapter/edgar-allan-poe/
  4. Note this opens in Via

Expected behavior
While the reproduction doesn't involve a site that relies on cookies or blocks proxies, if it did you would still want to be able to get to a given annotation on that site. Via will stop you from doing so even though Hypothesis is embedded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant