Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading bar color clashes on Checkmate malicious blocked pages #502

Open
seanh opened this issue May 19, 2021 · 0 comments
Open

Loading bar color clashes on Checkmate malicious blocked pages #502

seanh opened this issue May 19, 2021 · 0 comments

Comments

@seanh
Copy link
Contributor

seanh commented May 19, 2021

When a page is blocked because Checkmate thinks it's malicious the color of the loading bar is very similar to the background color of the page. Example:

https://via.hypothes.is/https://example.com/malicious

Slack thread: https://hypothes-is.slack.com/archives/C1M8NH76X/p1621360348014500

See also: Loading bar doesn't finish on Checkmate pages

Suggestions

Just use a different color

As long as the loading bar doesn't dynamically adapt its color it's always going to clash with some pages. But we should choose a color that doesn't clash with our own pages. Blue or purple are common loading bar colors.

Dynamically change the color

Pick two very different colors, say red and blue. Use a red loading bar by default. Detect the background color of the page and, if it's too similar to the red (color comparison algorithm required) then swap to the blue instead.

If our two color choices are far enough apart then a site can't be overly similar to both at once.

May require the loading bar to actually change color mid-load, when the website's background color appears.

Other ideas?

I think there might be better ways to dynamically adjust a loading bar's color based on the color behind it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant