Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not proxying 5xx status responses from upstream #65

Open
robertknight opened this issue Feb 10, 2021 · 1 comment
Open

Consider not proxying 5xx status responses from upstream #65

robertknight opened this issue Feb 10, 2021 · 1 comment

Comments

@robertknight
Copy link
Member

Proxying 5xx status responses from upstream interferes with monitoring tools that use this status code to detect internal errors in a service. While we probably can't avoid proxying 4xx statuses because client-side code may rely on it, we probably can get away with substituting 5xx status responses with an alternate value. This would allow us to rely on 5xx statuses to detect the rate of internal errors for example.

See Slack discussion: https://hypothes-is.slack.com/archives/CR3E3S7K8/p1612979225052500?thread_ts=1612975098.050300&cid=CR3E3S7K8

@seanh
Copy link
Collaborator

seanh commented Mar 11, 2021

The "Healthy threshold" on Via HTML prod was changed from "OK" to "Warning" to make it easier to deploy due to this issue. If we fix this issue, we might be able to change it back to "OK" again. https://hypothes-is.slack.com/archives/CR3E3S7K8/p1615459838040300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants