Version 0.4
#305
Annotations
12 warnings
you should consider adding a `Default` implementation for `EventStream`:
src/event_listener/stream.rs#L35
warning: you should consider adding a `Default` implementation for `EventStream`
--> src/event_listener/stream.rs:35:5
|
35 | / pub fn new() -> Self {
36 | | use crate::unix_async::*;
37 | | let stream = try_stream! {
... |
63 | | }
64 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
33 + impl Default for EventStream {
34 + fn default() -> Self {
35 + Self::new()
36 + }
37 + }
|
|
redundant closure:
src/event_listener/shared.rs#L903
warning: redundant closure
--> src/event_listener/shared.rs:903:26
|
903 | .map(|x| Address::new(x))
| ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Address::new`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/event_listener/shared.rs#L705
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/event_listener/shared.rs:705:30
|
705 | x.splitn(event.0 as usize, ",")
| ^^^^^^^^^^^^^^^^ help: try: `event.0`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
src/event_listener/shared.rs#L694
warning: very complex type used. Consider factoring parts into `type` definitions
--> src/event_listener/shared.rs:694:6
|
694 | ) -> crate::Result<Either<(ParsedEventType, Vec<String>), (String, String)>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
first doc comment paragraph is too long:
src/event_listener/shared.rs#L464
warning: first doc comment paragraph is too long
--> src/event_listener/shared.rs:464:1
|
464 | / /// This struct represents an unknown event to hyprland-rs
465 | | /// this allows you to use events that haven't been implemented in hyprland-rs.
466 | | /// To use this use the [UnknownEventData::parse_args] method to properly get the args
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
|
this lifetime isn't used in the function definition:
src/event_listener/shared.rs#L75
warning: this lifetime isn't used in the function definition
--> src/event_listener/shared.rs:75:35
|
75 | pub(crate) fn event_primer_noexec<'a>(
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
= note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|